Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Commit ff668221 reintroduces failure mode of issue #116 #130

Closed
bska opened this issue Jul 25, 2013 · 2 comments
Closed

Commit ff668221 reintroduces failure mode of issue #116 #130

bska opened this issue Jul 25, 2013 · 2 comments

Comments

@bska
Copy link
Contributor

bska commented Jul 25, 2013

It appears that commit ff66822 (inadvertently?) reintroduces -Werror into the ERT build flags (devel/CMakeLists.txt) which causes the same type of problems as was outlined in issue #116. Was that intended?

@joakim-hove
Copy link
Contributor

Ahhh - commits and branches and ... - so many possibilites to mess up. Yes it was indeed inadvertedly - reverting again asap.

However - I still wish to set -Werror as default, but I very much intend to include you in that process.

@bska
Copy link
Contributor Author

bska commented Jul 25, 2013

I still wish to set -Werror as default, but I very much intend to include [me] in that process.

I'd be happy to contribute. For the record, these are the flags I'm currently using when building the ERT:

-pipe -std=c99 -pedantic -Wall -Wextra -Wformat-nonliteral -Wcast-align -Wpointer-arith -Wbad-function-cast -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Wundef -Wnested-externs -Wcast-qual -Wshadow -Wwrite-strings -Wchar-subscripts -Wredundant-decls

Those may be too strict though.

@bska bska closed this as completed Jul 25, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants