Build issues caused by configuration mismatches or missing header

[atgeirr]

In a different library (opm-core) I get the following error message:

In file included from /Users/atgeirr/opm/opm-core/examples/import_rewrite.cpp:11:0:
/usr/local/include/ert/util/util.h:435:23: fatal error: util_fork.h: No such file or directory

This line is compiled because my (opm-core) config.h contains the line

#define HAVE_FORK 1

However, util_fork.h does not get installed by ert. The ert_build_config.h file contains

#define HAVE_FORK

without the 1, I do not know if this is significant.

In general, I guess opm-core must make a configuration header that is a perfect superset of ert's header, or I can get into trouble. The best would be to have no configuration dependencies in any installed ert header, but that may not be feasible.

[joakim-hove]

OK;

see merged PR: #49. The PR removes the -fno-leading-underscore which was some ancient desperate windows attempt.

The content of (missing) header file util_fork.h is inlined in the main header file util.h, and things 'should work' now - however you are addressing an important issue with the build config header (which is not used at all for the moment - I think ....). My experience from ert is of course mainly to build and use ert itself, not building other codes which depend on ert; I therefor fully understand that ert does not behave optimally for other libraries. I will

[joakim-hove]

ehh - a bit premature send here:

My point is that I am aware that way is build config is exported from ert to e.g. opm-core is not 100%, and that I will be more than happy to fix it; suggestions accepted.

[atgeirr]

This issue is now resolved, thanks!