Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure parse errors retain all tokens from the source #4685

Closed
wdanilo opened this issue Feb 5, 2023 · 0 comments
Closed

Ensure parse errors retain all tokens from the source #4685

wdanilo opened this issue Feb 5, 2023 · 0 comments
Assignees
Labels
-parser p-low Low priority x-new-feature Type: new feature request

Comments

@wdanilo
Copy link
Member

wdanilo commented Feb 5, 2023

This task is automatically imported from the old Task Issue Board and it was originally created by Keziah Wesley.
Original issue is here.


Every token in the source must appear in the output exactly once, in order; this is not always straightforward for error cases. Add tests exercising every code path that creates an Invalid node, and ensure they pass the parse-print round-trip test.

Comments:

Keziah Wesley reports a new STANDUP for today (2022-11-08):

Progress: Went over all error cases to ensure they represented all the input source, so ability to report syntax errors properly won't block #3611. Developed a plan (#183755412) to replace tracing with profiler to solve a performance problem (#183721914). It should be finished by 2022-11-08.

Next Day: Next day I will be working on the #183647442 task. Finish up loosening allowable type-definition bodies. (Enso Bot - Nov 9, 2022)


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-parser p-low Low priority x-new-feature Type: new feature request
Projects
None yet
Development

No branches or pull requests

2 participants