Error handling is run multiple times on the same module

[wdanilo]

This task is automatically imported from the old Task Issue Board and it was originally created by Hubert Plociniczak.
Original issue is here.

---

@radek reported internally a problem where the same error has been reported multiple times for no apparent reason. This has occurred on his branch #4027.

I'm unable to reproduce this on a small problem but a quick review revealed another problem - https://github.com/enso-org/enso/blob/develop/engine/runtime/src/main/scala/org/enso/compiler/Compiler.scala#L784 appears to contain duplicate module names. Gathering diagnostics for the same module and not removing duplicates is bound to produce the same errors multiple times.

Comments:

I'd keep the particular commit reference, as I fixed the missing imports problem that was triggering the bug already.

The commit where the bug is reproducible was 8a4dd6f

I'm wondering if it's worth tagging it, as otherwise it may get lost after a rebase etc.

The particular repro was to run

enso run test/Table_Tests/src/Common_Table_Operations/Integration_Tests.enso

or

built-distribution/enso-engine-0.0.0-dev-linux-amd64/enso-0.0.0-dev/bin/enso --no-ir-caches  --run test/Table_Tests/src/Common_Table_Operations/Integration_Tests.enso --in-project test/Table_Tests

Interestingly running in project entry point mode - enso run test/Table_Tests seems to not show the issue. Seems like it is related to running a particular file from the project. (Radosław Waśko - Jan 10, 2023)

---