Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce exponential backoff when IDE reconnects with backend #5066

Closed
wdanilo opened this issue Feb 5, 2023 · 2 comments
Closed

Introduce exponential backoff when IDE reconnects with backend #5066

wdanilo opened this issue Feb 5, 2023 · 2 comments
Assignees
Labels
p-low Low priority x-new-feature Type: new feature request

Comments

@wdanilo
Copy link
Member

wdanilo commented Feb 5, 2023

This task is automatically imported from the old Task Issue Board and it was originally created by Hubert Plociniczak.
Original issue is here.


Currently if we kill backend (LS), IDE will keep on trying to reconnect at the same rate which is not particularly useful. Neither is the message Connection to the backend has been lost. Please try restarting IDE.

We should:

  • apply gmail strategy which uses exponential backoff to reconnect in case of failure
  • update the message with the information on when IDE would attempt to reconnect
  • preferably provide a more visible error message at the top (gray on white is easy to miss)

Discussion thread: https://discord.com/channels/401396655599124480/1069912865261240371

@sylwiabr sylwiabr moved this to ❓New in Issues Board Feb 6, 2023
@sylwiabr sylwiabr added triage and removed p-low Low priority labels Feb 7, 2023
@4e6 4e6 assigned 4e6 and JaroslavTulach and unassigned 4e6 Feb 8, 2023
@4e6 4e6 removed the triage label Feb 8, 2023
@JaroslavTulach JaroslavTulach removed their assignment Feb 10, 2023
@Frizi
Copy link
Contributor

Frizi commented Feb 10, 2023

Depends on #5202. Once the reconnection procedure itself is implemented, adding exponential backoff should be purely IDE side modification.

@Frizi Frizi removed the triage label Feb 10, 2023
@jdunkerley jdunkerley modified the milestone: Beta Release Feb 21, 2023
@farmaazon farmaazon added p-low Low priority g-controller d-hard Difficulty: significant prior knowledge required and removed --bug Type: bug d-hard Difficulty: significant prior knowledge required labels Feb 21, 2023
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Feb 21, 2023
@farmaazon
Copy link
Contributor

Superseded by #8520

@farmaazon farmaazon closed this as not planned Won't fix, can't repro, duplicate, stale Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-low Low priority x-new-feature Type: new feature request
Projects
None yet
Development

No branches or pull requests

7 participants