Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate HTML docs from Rust documentation AST #5670

Closed
kazcw opened this issue Feb 15, 2023 · 3 comments
Closed

Generate HTML docs from Rust documentation AST #5670

kazcw opened this issue Feb 15, 2023 · 3 comments
Assignees
@kazcw
Labels
--low-performance
Milestone
Beta Release

Comments

@kazcw
Copy link
Contributor

kazcw commented Feb 15, 2023 •
edited
Loading

Depends on: #5448

The frontend is currently spending about a quarter of its CPU time running the Scala documentation parser. The Rust parser can be 100x faster. Also, this is the last thing blocking us from eliminating the Scala parser entirely.
@kazcw kazcw self-assigned this Feb 15, 2023
@kazcw kazcw mentioned this issue Feb 15, 2023
Closed
@wdanilo
Copy link
Member

wdanilo commented Feb 19, 2023

Out of curiosity - what is your approx estimate for it Kaz?

@vitvakatu
Copy link
Contributor

vitvakatu commented Feb 20, 2023 •
edited by unfurl-links bot
Loading

Wait, we don't want to generate the actual HTML, do we? It would be ideal to generate better DocSections, but without much HTML code, as I described here: https://discord.com/channels/401396655599124480/1063461140794986636/1063461140794986636

Discord
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.

@jdunkerley jdunkerley added this to the Beta Release milestone Feb 22, 2023
@kazcw
Copy link
Contributor Author

kazcw commented Mar 3, 2023

We no longer need HTML docs in the frontend.

@kazcw kazcw closed this as not planned Won't fix, can't repro, duplicate, stale Mar 3, 2023
@github-project-automation github-project-automation bot moved this from ❓New to 🟢 Accepted in Issues Board Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kazcw kazcw

Labels
--low-performance
Projects
Issues Board
Archived in project
Milestone
Beta Release
Development

No branches or pull requests
4 participants
@kazcw @wdanilo @jdunkerley @vitvakatu