Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regex Compile needs a fallback for the built in #7287

Closed
jdunkerley opened this issue Jul 13, 2023 · 0 comments · Fixed by #7297
Closed

Regex Compile needs a fallback for the built in #7287

jdunkerley opened this issue Jul 13, 2023 · 0 comments · Fixed by #7297
Assignees
@GregoryTravis
Labels
-compiler -libs Libraries: New libraries to be implemented
Milestone
Beta Release

Comments

@jdunkerley
Copy link
Member

jdunkerley commented Jul 13, 2023 •
edited
Loading

Within engine/runtime/src/main/java/org/enso/interpreter/node/expression/builtin/text/RegexCompileNode.java, there is no @Fallback if the types passed as invalid.

We should Panic with a Type error if not valid.
@jdunkerley jdunkerley converted this from a draft issue Jul 13, 2023
@jdunkerley jdunkerley added this to the Beta Release milestone Jul 13, 2023
@jdunkerley jdunkerley added the -libs Libraries: New libraries to be implemented label Jul 13, 2023
@jdunkerley jdunkerley mentioned this issue Jul 13, 2023
Closed
@GregoryTravis GregoryTravis linked a pull request Jul 14, 2023 that will close this issue
Add Fallback to Prim_Text_Helper.compile_regex; accept Regex in Text.parse_to_table #7297
Merged
5 tasks
@jdunkerley jdunkerley moved this from 📤 Backlog to 👁️ Code review in Issues Board Jul 18, 2023
@mergify mergify bot closed this as completed in #7297 Jul 18, 2023
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GregoryTravis GregoryTravis

Labels
-compiler -libs Libraries: New libraries to be implemented
Projects
Issues Board
Archived in project
Milestone
Beta Release
Development

Successfully merging a pull request may close this issue.

Add Fallback to Prim_Text_Helper.compile_regex; accept Regex in Text.parse_to_table enso-org/enso
3 participants
@jdunkerley @GregoryTravis @JaroslavTulach