Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropping a connection onto the component name should be equivalent to dropping onto the icon #9212

Closed
AdRiley opened this issue Feb 28, 2024 · 1 comment · Fixed by #9439
Closed

Dropping a connection onto the component name should be equivalent to dropping onto the icon #9212

AdRiley opened this issue Feb 28, 2024 · 1 comment · Fixed by #9439
Assignees
@kazcw
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints
Milestone
Beta Release

Comments

@AdRiley
Copy link
Member

AdRiley commented Feb 28, 2024

If I try to reconnect a different input to a component and drop my new connection on the name instead of the icon

image

Bad things happen

image

Dropping on the component name should have the same functionality as dropping on the component icon
@AdRiley AdRiley added the -gui label Feb 28, 2024
@AdRiley AdRiley added this to the Beta Release milestone Feb 28, 2024
@farmaazon farmaazon added d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints labels Feb 29, 2024
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Feb 29, 2024
@kazcw
Copy link
Contributor

kazcw commented Mar 14, 2024

What happened to our refinement notes for this? IIRC, we decided:

  • Introduce conditional ports, which can only be connection targets while a key is held
  • When a WidgetSelection for an Ast.PropertyAccess has a WidgetSelfIcon or a widget with a conditional port on its LHS, its port should be conditional.

@kazcw kazcw self-assigned this Mar 14, 2024
@kazcw kazcw moved this from 📤 Backlog to 🔧 Implementation in Issues Board Mar 14, 2024
@kazcw kazcw linked a pull request Mar 14, 2024 that will close this issue
Self-argument access chain ports are conditional #9439
Merged
5 tasks
@kazcw kazcw moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Mar 15, 2024
@mergify mergify bot closed this as completed in #9439 Mar 18, 2024
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kazcw kazcw

Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints
Projects
Issues Board
Archived in project
Milestone
Beta Release
Development

Successfully merging a pull request may close this issue.

Self-argument access chain ports are conditional enso-org/enso
3 participants
@kazcw @AdRiley @farmaazon