Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import functions used as accessors #1

Merged
merged 18 commits into from
Jan 25, 2017
Merged

Import functions used as accessors #1

merged 18 commits into from
Jan 25, 2017

Conversation

mikusp
Copy link

@mikusp mikusp commented Jan 23, 2017

No description provided.

@mikusp mikusp requested a review from kustosz January 23, 2017 10:32
@kustosz
Copy link
Contributor

kustosz commented Jan 23, 2017

Can you move the implementations out of test files?

@kustosz
Copy link
Contributor

kustosz commented Jan 24, 2017

LGTM

@kustosz
Copy link
Contributor

kustosz commented Jan 24, 2017

Except one thing tho: get rid of the type-holes in the test files.

@kustosz kustosz merged commit 267d228 into master Jan 25, 2017
@kustosz kustosz deleted the pass/accessorfunction branch January 25, 2017 12:41
iamrecursion pushed a commit that referenced this pull request Aug 10, 2018
* Deriving storable instances

* Handle no-param constructors + fix a siiiilyyyy mistake
iamrecursion added a commit that referenced this pull request Feb 22, 2019
* Relax bounds on base.

* Increase upper bound for base.
iamrecursion added a commit that referenced this pull request Feb 22, 2019
* Relax bounds on base.

* Increase upper bound for base.
iamrecursion added a commit that referenced this pull request Feb 23, 2019
* Relax bounds on base.

* Increase upper bound for base.

* Update package.yaml
iamrecursion added a commit that referenced this pull request Feb 23, 2019
* Relax bounds on base.

* Increase upper bound on base.

* Bump version.
iamrecursion added a commit that referenced this pull request Feb 23, 2019
* Increase upper bound on base and relax lower bound.

* Bump version.
radeusgd added a commit that referenced this pull request Mar 16, 2023
radeusgd added a commit that referenced this pull request Mar 16, 2023
radeusgd added a commit that referenced this pull request Mar 18, 2023
radeusgd added a commit that referenced this pull request Mar 20, 2023
radeusgd added a commit that referenced this pull request Mar 21, 2023
radeusgd added a commit that referenced this pull request Mar 22, 2023
radeusgd added a commit that referenced this pull request Mar 22, 2023
radeusgd added a commit that referenced this pull request Mar 22, 2023
radeusgd added a commit that referenced this pull request Mar 23, 2023
radeusgd added a commit that referenced this pull request Mar 23, 2023
radeusgd added a commit that referenced this pull request Mar 23, 2023
radeusgd added a commit that referenced this pull request Mar 27, 2023
radeusgd added a commit that referenced this pull request Mar 27, 2023
radeusgd added a commit that referenced this pull request Mar 28, 2023
radeusgd added a commit that referenced this pull request Mar 28, 2023
radeusgd added a commit that referenced this pull request Mar 28, 2023
radeusgd added a commit that referenced this pull request Mar 29, 2023
radeusgd added a commit that referenced this pull request Mar 31, 2023
radeusgd added a commit that referenced this pull request Mar 31, 2023
@MrFlashAccount MrFlashAccount mentioned this pull request May 14, 2024
4 tasks
@somebody1234 somebody1234 mentioned this pull request Jul 22, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants