Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay setting project state to Opened until backend is fully ready #6426

Closed
wants to merge 318 commits into from

Conversation

somebody1234
Copy link
Contributor

@somebody1234 somebody1234 commented Apr 25, 2023

Pull Request Description

Fixes cloud-v2/#351

Important Notes

Not tested as I'm not sure how to repro the opening-a-project-before-it's-actually-ready thing.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@somebody1234 somebody1234 added the CI: No changelog needed Do not require a changelog entry for this PR. label Apr 25, 2023
@somebody1234
Copy link
Contributor Author

:| woops

@somebody1234
Copy link
Contributor Author

(sorry everyone, bad merge)

@somebody1234
Copy link
Contributor Author

so it seems like this may not be needed because this might be getting implemented directly in the backend

@somebody1234 somebody1234 marked this pull request as draft April 26, 2023 08:34
@PabloBuchu
Copy link
Contributor

@somebody1234 for now we need this little workaround.

Loading animation should be going on until it receives also 200 response from /resources endpoint. Currently once the project is Opened you call the /resource once. After 3s it timeouts and you receives 500 (because its aws lambda timeout not runtimes one, but we will fix that on backend - I guess returning 400 or something).

Can we improve this to make the loading icon spin until setState is success? Also we should check /resource also in interval

@somebody1234 somebody1234 marked this pull request as ready for review April 26, 2023 13:59
Base automatically changed from wip/sb/cloud-desktop-mode-switcher to develop April 26, 2023 14:59
@wdanilo
Copy link
Member

wdanilo commented Apr 27, 2023

Ok, few questions:

  1. Is almost 2k changed lines really needed for "Delay setting project state to Opened until backend is fully ready"? This sounds very strange.
  2. The description states "Not tested as I'm not sure how to repro the opening-a-project-before-it's-actually-ready thing." - this needs to be tested before merge.
  3. Ping me when Q/A will be ready, then I'll review it.

@somebody1234
Copy link
Contributor Author

re: #1 - it was based on the cloud desktop backend switcher PR - it was ~10 lines before the revert. I'll be marking as draft until that's been sorted out

@somebody1234 somebody1234 marked this pull request as draft April 27, 2023 04:08
@somebody1234
Copy link
Contributor Author

closing as it has been cherry-picked to #6448

@somebody1234 somebody1234 deleted the wip/sb/delay-opened-state branch April 29, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants