Editions Integration #1832
Editions Integration #1832
Conversation
radeusgd
force-pushed
the
wip/rw/editions-integration
branch
from
ca85414
to
8c0269c
Compare
| .replace("std-lib/", "std-lib/" + outDir + "/") | ||
| .replace("lib/Standard/", outDir + "/") | ||
| .replace("Main.js", "index.js") | ||
| // TODO [RW] update this once library versions are changing | ||
| .replace("/0.1.0/", "/") |
There was a problem hiding this comment.
@BinarySoftware can you have a look at it?
The docs seem to run, but I'm not exactly sure what these artifacts should look like so it is hard to tell if I didn't break something in a more subtle way. Would really appreciate if you could double check if these changes did not break the docs.
There was a problem hiding this comment.
why not just repace by regex?
from /0.1.0/ to \/\d+\.\d+\.\d+\/?
There was a problem hiding this comment.
Because currently the version is hardcoded anyway and once it is changed, this regex will not suffice (as the version can contain a SNAPSHOT suffix and other stuff).
Since this will need to be changed anyway (or maybe will be completely changed before the version stops being hardcoded), I don't think a regex is necessary now.
engine/runtime/src/main/java/org/enso/interpreter/runtime/Context.java
Outdated
Show resolved
Hide resolved
- editions are resolved upon context init
Now it does not create a dummy edition with default version, but uses the proper default edition.
radeusgd
force-pushed
the
wip/rw/editions-integration
branch
from
3dd18d8
to
4ab241f
Compare
Pull Request Description
Closes #1781, integrates the functionality of #1826 with the editions system and updates the layout of the Standard library to comply with the new library layout.
Important Notes
Checklist
Please include the following checklist in your PR: