Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nightly Workflows and Update Release Policy #1845

Merged
merged 5 commits into from
Jul 9, 2021
Merged

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Jul 9, 2021

Pull Request Description

My previous PR that integrated the editions system (#1832) did introduce default editions tied to each engine version.

However I forgot to mention that after performing a release this edition number must be bumped and also that the nightly workflows should set this edition name to a nightly-specific name. Without this, editions from nightlies and releases could conflict leading to unexpected engine versions possibly being selected if multiple versions sharing the same edition name are installed.

This PR fixes that by updating the release policy, doing the overdue edition bump and adding automatic edition bumping to the nightly workflow.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@radeusgd radeusgd self-assigned this Jul 9, 2021
@radeusgd radeusgd added Category: Build p-highest Should be completed ASAP labels Jul 9, 2021
@radeusgd radeusgd merged commit 042a0f8 into main Jul 9, 2021
@radeusgd radeusgd deleted the wip/rw/fix-nightlies branch July 9, 2021 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-highest Should be completed ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants