Component Group View with static header and without icons #3373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdanilo
approved these changes
Apr 14, 2022
| header_text_size <- all(&header_text_size, &init)._0(); | ||
| model.header.set_default_text_size <+ header_text_size.map(|v| text::Size(*v)); | ||
| _set_header <- input.set_header.map2(&size_and_header_geometry, f!( | ||
| (t, (size, hdr_geom)) { |
There was a problem hiding this comment.
what is t? It is really poorly named variable
|
|
||
| /// An entry point. | ||
| #[entry_point] | ||
| #[allow(dead_code)] |
|
(Process note: the code-review is now Approved, therefore the PR is waiting for an Acceptance/QA Review by @vitvakatu on Task https://www.pivotaltracker.com/story/show/181724889 before merge.) |
vitvakatu
approved these changes
Apr 14, 2022
hubertp
pushed a commit
that referenced
this pull request
Apr 19, 2022
Add an initial version of the visual component for displaying the Component Group View. The component contains a header (for displaying the Group Name) and a list of labels (for displaying the component names). https://www.pivotaltracker.com/story/show/181724889 #### Visuals A screenshot from a debug scene demonstrating the component: <img width="251" alt="Screenshot 2022-04-13 at 20 07 56" src="https://user-images.githubusercontent.com/273837/163243304-21c3ad78-4813-4368-b3bb-844d979da699.png"> Screenshots from other debug scenes (`list_view` and `text_area`), demonstrating that the other components still display correctly: <img width="202" alt="Screenshot 2022-04-13 at 20 08 56" src="https://user-images.githubusercontent.com/273837/163243428-de9dc1c7-5a9f-45e0-9325-db60cece9768.png"> <img width="403" alt="Screenshot 2022-04-13 at 20 08 48" src="https://user-images.githubusercontent.com/273837/163243432-895061d9-5bd9-4349-8679-eb63b0f6724d.png"> A screenshot of the Node Searcher's list, showing that long entries in a ListView are now truncated, and an ellipsis character is added in place of removed characters: <img width="651" alt="Screenshot 2022-04-13 at 20 10 16" src="https://user-images.githubusercontent.com/273837/163243664-5b671969-7aa0-4bef-8fd2-825602d85848.png"> # Important Notes - Adding support for the text truncation feature in `ListView` required some changes in the`list_view::Entry`-related APIs. - An embedded font was added (DejaVuSans-Bold) for use in the Component Group View debug scene, and 5 unused embedded fonts were removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Add an initial version of the visual component for displaying the Component Group View. The component contains a header (for displaying the Group Name) and a list of labels (for displaying the component names).
https://www.pivotaltracker.com/story/show/181724889
Visuals
A screenshot from a debug scene demonstrating the component:
Screenshots from other debug scenes (
list_viewandtext_area), demonstrating that the other components still display correctly:A screenshot of the Node Searcher's list, showing that long entries in a ListView are now truncated, and an ellipsis character is added in place of removed characters:
Important Notes
ListViewrequired some changes in thelist_view::Entry-related APIs.Checklist
Please include the following checklist in your PR:
./run distand./run watch.