SDF-based mechanism for making letters bold #3385

farmaazon · 2022-04-07T12:36:05Z

Pull Request Description

Fixes 181641027. There are new methods of text::Area for making some letters bolder, without moving them nor any other letters in the line.

Tested on DejaVuSans text:

On MacOS:

Important Notes

Checklist

Please include the following checklist in your PR:

The documentation has been updated if necessary.
All code conforms to the Scala, Java, and Rust style guides.
All code has been tested:
- Unit tests have been written where possible.
- If GUI codebase was changed: Enso GUI was tested when built using BOTH ./run dist and ./run watch.

wdanilo

Beautiful! ✨👀✨

wdanilo · 2022-04-08T04:13:18Z

lib/rust/ensogl/component/text/src/component/area.rs

+        self.display_object.add_child(&glyph_system);
+        let old_glyph_system = self.glyph_system.replace(glyph_system);
+        self.display_object.remove_child(&old_glyph_system);
+        // remove old Glyph structures, as they still refer to the old Glyph System.


wdanilo · 2022-04-08T04:13:40Z

lib/rust/ensogl/component/text/src/typeface/glsl/glyph.glsl

 highp float median(highp vec3 v) {
    return max(min(v.x, v.y), min(max(v.x, v.y), v.z));
 }

+// To smaple the msdf properly, the boundaries of our uv should be in the middle of msdf cells.


Plus, I dont understand this comment – what do you mean by "boundaries" to be in the middle of msdf cells? Could you explain it better, please?

I changed the name and comment. Would you like to check if it's better?

wdanilo · 2022-04-08T04:15:47Z

lib/rust/ensogl/component/text/src/typeface/glsl/glyph.glsl

+    bool glyph_is_bold            = (input_style & STYLE_BOLD_FLAG) != 0;
+    highp vec2  local_to_px_ratio = 1.0 / fwidth(input_local.xy);
+    highp float font_size_px      = input_font_size * (local_to_px_ratio.x + local_to_px_ratio.y) / 2.0;
+    return glyph_is_bold ? font_size_px * BOLD_FATTING : 0.0;


Instead of bold / not bold the user might set how much bold the font sohuld be – this will be even a nicer setting – new fonts are made this way (see dynamic bold fonts on google fonts). What do you think of such a design instead? I'm OK with the current one though!

The question is if we want to use Bold-version of fonts in the future. If yes, then I would keep consistent API.

wdanilo · 2022-04-08T04:16:44Z

lib/rust/ensogl/component/text/src/typeface/glsl/glyph_mac.glsl

+// A factor describing much the bold letters will be fattened, expressed as the fraction of font size.
+const float BOLD_FATTING = 0.04;
+


the file for non-mac has more changes, is it intentional?

No, not all realignments/refactorings were moved. However, logic changes should be the same.

MichaelMauderer · 2022-04-08T09:50:58Z

I did not do a review of this, but just a note: Is this meant to be a replacement for actually using a bold font? This will not do many of the things that will happen if a properly bolded font is used (like updating the letter spacing etc., so this can lead to many visual glitches if used improperly, and should try to do proper font rendering instead.

MichaelMauderer · 2022-04-08T09:53:26Z

lib/rust/ensogl/component/text/src/typeface/glyph.rs

+        self.style.get() & style_flag::BOLD != 0
+    }
+
+    pub fn set_bold(&self, value: bool) {


We should be super careful about the naming. This is not proper bolding of the text. We should reserve the default names for the proper implementation that updates the font correctly.

very good catch, thats really important!

Solves the issue of defaulted args not being called in atoms. Doesn't solve the more general function issue.

wdanilo

Let's merge it! Few notes:

The Michaels comment about naming is very important, I completely overlooked it during my review.
"Normal" fonts are using float as bold indicator more nad more often. Almost all web fonts are moving now to "variable fonts" definition (https://fonts.google.com/knowledge/using_type/styling_type_on_the_web_with_variable_fonts). This is just FYI, we dont need to support it really so a flag bold/not bold is enough for us :)

akavel · 2022-04-12T11:10:35Z

Acceptance/QA passed.

Note: For QA, I extended the debug scene to make it easier to visually inspect that the width and positions of characters are maintained. Some complex unicode is not rendered correctly by text::Area, but fixing that is not in the scope of this task. The SDF mechanism appears to be working correctly even in complex cases and on characters composed of disjoint areas.

This reverts commit 79258c9.

…-sdf-bold-181641027

Fixes [181641027](https://www.pivotaltracker.com/story/show/181641027). There are new methods of text::Area for making some letters bolder, without moving them nor any other letters in the line. Tested on DejaVuSans text: ![image](https://user-images.githubusercontent.com/3919101/162199723-524f7560-535f-4c98-bcb4-6b760ad8cb04.png) ![image](https://user-images.githubusercontent.com/3919101/162199806-e6582c56-3071-4653-8ad2-114df86cd6b7.png) ![image](https://user-images.githubusercontent.com/3919101/162199880-1836e902-8663-4696-bcb7-2b15c3c243c6.png) On MacOS: <img width="824" alt="Screenshot 2022-04-07 at 14 54 40" src="https://user-images.githubusercontent.com/3919101/162203730-ffda3096-7aab-443f-a45a-bfa18784ba36.png"> <img width="379" alt="Screenshot 2022-04-07 at 14 54 52" src="https://user-images.githubusercontent.com/3919101/162203751-f5ca2e26-fdb6-4521-9821-999111b80ac0.png"> <img width="160" alt="Screenshot 2022-04-07 at 14 54 58" src="https://user-images.githubusercontent.com/3919101/162203769-3c367f81-67bb-48aa-994c-42eeb131017e.png">

farmaazon added 9 commits April 7, 2022 11:13

WIP

ff13403

Bold letters in SDF

af0e995

Working TextArea with SDF bold text

2290605

Refactored some constants

0a944a6

Fix

595f918

Added set_font method

76418de

Linter fix

c8c8626

Make bold factor actually depending on the font size

8a1ffe1

Apply lint comment

612d944

farmaazon self-assigned this Apr 7, 2022

farmaazon added 2 commits April 7, 2022 14:39

Self-review + fix GLSL for mac

f401664

Add CHANGELOG note

eacadd7

farmaazon marked this pull request as ready for review April 7, 2022 12:57

farmaazon requested review from MichaelMauderer, wdanilo, 4e6 and mwu-tow as code owners April 7, 2022 12:57

wdanilo approved these changes Apr 8, 2022

View reviewed changes

farmaazon added 2 commits April 8, 2022 10:07

Merge branch 'develop' into wip/farmaazon/text-sdf-bold-181641027

a649c4b

Apply @wdanilo review

9aa470a

MichaelMauderer reviewed Apr 8, 2022

View reviewed changes

farmaazon and others added 2 commits April 11, 2022 12:27

Highlight !== Bold

5cd746d

Always call defaulted atom arguments (#3358)

f75b6be

Solves the issue of defaulted args not being called in atoms. Doesn't solve the more general function issue.

farmaazon requested review from jdunkerley and radeusgd as code owners April 11, 2022 10:30

wdanilo approved these changes Apr 11, 2022

View reviewed changes

Merge branch 'develop' into wip/farmaazon/text-sdf-bold-181641027

b7ca2a6

farmaazon removed request for radeusgd and jdunkerley April 11, 2022 13:00

farmaazon added the CI: Ready to merge This PR is eligible for automatic merge label Apr 11, 2022

Merge branch 'develop' into wip/farmaazon/text-sdf-bold-181641027

5bb9fe7

farmaazon removed the CI: Ready to merge This PR is eligible for automatic merge label Apr 11, 2022

farmaazon and others added 2 commits April 12, 2022 11:40

Rename "highlight" to "dilate"

79258c9

QA: extend debug scene for visual inspection

250bd34

farmaazon added 2 commits April 12, 2022 14:52

Revert "Rename "highlight" to "dilate""

8d9ae69

This reverts commit 79258c9.

Rename again

c951849

farmaazon added the CI: Ready to merge This PR is eligible for automatic merge label Apr 12, 2022

Merge remote-tracking branch 'origin/develop' into wip/farmaazon/text…

2ee2a65

…-sdf-bold-181641027

farmaazon force-pushed the wip/farmaazon/text-sdf-bold-181641027 branch from 9cdfc6d to 2ee2a65 Compare April 12, 2022 16:12

Merge remote-tracking branch 'origin/develop' into wip/farmaazon/text…

7b75fda

…-sdf-bold-181641027

mergify bot merged commit 8ca4e2b into develop Apr 12, 2022

mergify bot deleted the wip/farmaazon/text-sdf-bold-181641027 branch April 12, 2022 17:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SDF-based mechanism for making letters bold #3385

SDF-based mechanism for making letters bold #3385

farmaazon commented Apr 7, 2022 •

edited

Loading

wdanilo left a comment

wdanilo Apr 8, 2022

wdanilo Apr 8, 2022

wdanilo Apr 8, 2022

farmaazon Apr 8, 2022

wdanilo Apr 8, 2022

farmaazon Apr 8, 2022 •

edited

Loading

wdanilo Apr 8, 2022

farmaazon Apr 8, 2022

MichaelMauderer commented Apr 8, 2022

MichaelMauderer Apr 8, 2022

wdanilo Apr 11, 2022

wdanilo left a comment

akavel commented Apr 12, 2022 •

edited

Loading

		// A factor describing much the bold letters will be fattened, expressed as the fraction of font size.
		const float BOLD_FATTING = 0.04;

SDF-based mechanism for making letters bold #3385

SDF-based mechanism for making letters bold #3385

Conversation

farmaazon commented Apr 7, 2022 • edited Loading

Pull Request Description

Important Notes

Checklist

wdanilo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

farmaazon Apr 8, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MichaelMauderer commented Apr 8, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wdanilo left a comment

Choose a reason for hiding this comment

akavel commented Apr 12, 2022 • edited Loading

farmaazon commented Apr 7, 2022 •

edited

Loading

farmaazon Apr 8, 2022 •

edited

Loading

akavel commented Apr 12, 2022 •

edited

Loading