Always call defaulted atom arguments #3358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdunkerley
reviewed
Mar 23, 2022
engine/runtime/src/main/scala/org/enso/compiler/phase/StubIrBuilder.scala
Show resolved
Hide resolved
jdunkerley
approved these changes
Mar 23, 2022
hubertp
approved these changes
Mar 24, 2022
| @@ -718,7 +718,7 @@ object BindingsMap { | |||
| * @param name the name of the constructor. | |||
| * @param arity the number of fields in the constructor. | |||
| */ | |||
| case class Cons(name: String, arity: Int) | |||
| case class Cons(name: String, arity: Int, allFieldsDefaulted: Boolean) | |||
4e6
approved these changes
Apr 8, 2022
farmaazon
pushed a commit
that referenced
this pull request
Apr 11, 2022
Solves the issue of defaulted args not being called in atoms. Doesn't solve the more general function issue.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Solves the issue of defaulted args not being called in atoms. Doesn't solve the more general function issue.
Important Notes
Checklist
Please include the following checklist in your PR:
./run distand./run watch.