Refactor methods of Managed_Resource #3460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Promoted `with`, `take`, `finalize` to be methods of Managed_Resource rather than static methods always taking `resource`, for consistency reasons. This required function dispatch boilerplate, similarly to `Ref`. In future iterations we will address this boilerplate code. Related to https://www.pivotaltracker.com/story/show/182212217
hubertp
requested review from
4e6,
jdunkerley,
radeusgd,
JaroslavTulach,
MichaelMauderer and
PabloBuchu
as code owners
JaroslavTulach
approved these changes
May 18, 2022
jdunkerley
approved these changes
May 18, 2022
radeusgd
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Promoted
with,take,finalizeto be methods of Managed_Resourcerather than static methods always taking
resource, for consistencyreasons.
This required function dispatch boilerplate, similarly to
Ref.In future iterations we will address this boilerplate code.
Related to https://www.pivotaltracker.com/story/show/182212217
Checklist
Please include the following checklist in your PR:
./run distand./run watch.