-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update profiling CLI arguments #3461
Conversation
engine/language-server/src/main/scala/org/enso/languageserver/boot/MainModule.scala
Outdated
Show resolved
Hide resolved
engine/language-server/src/main/scala/org/enso/languageserver/runtime/ContextRegistry.scala
Outdated
Show resolved
Hide resolved
One more request. The IDE logs events it sends to the language server engine runtime. Can we make sure the same events, with the same IDs and similar timestamps are in the generated |
bfb0cb1
to
585bbaf
Compare
9892867
to
85e157d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this in and let's see how well it works!
|
||
case Some(serverContext) => | ||
for { | ||
_ <- stopSampling(serverContext) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, this looks like fine order of actions. Stopping sampling before terminating Truffle.
The logging goes through the central logging service. I updated the logic, and not it also produces the profiling log when the profiling is enabled. This way the log captures all the messages as the previous solution with the Java log handler was only able to capture logs from within the runtime. |
Pull Request Description
PR adds/updates CLI flags:
--profiling-events-log-path <file>
enable the event logging with ability to specify the file to store the messages between the runtime and the language server--profiling-path <file>
enable the application profiling with ability to specify the file to store the.npss
sampling statistics--profiling-time <seconds>
limits the application profiling time. If not specified, the profiling is stopped on the application shutdownImportant Notes
Checklist
Please include the following checklist in your PR:
Unit tests have been written where possible.If GUI codebase was changed: Enso GUI was tested when built using BOTH./run dist
and./run watch
.