from/all import must not include module in name resolution #3931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubertp
requested review from
jdunkerley,
radeusgd,
4e6 and
JaroslavTulach
as code owners
hubertp
changed the title
It appears that when were doing
`from XYZ import all`
the module `XYZ` was also being taken into account during name
resolution.
This was unfortunate and became problematic when one had a type with the
same name defined in it.
During pattern matching one could not simply do
```
from XYZ import all
...
case ... of
_ : XYZ -> ...
```
since the compiler would complain that we try to pattern match on a type
but give it a module.
The module is now excluded from the name resolution, when importing
everything from the module.
It appears that this "feature" was used in a number of our tests,
so they had to be adapted.
This fixes task 4 in https://www.pivotaltracker.com/story/show/183833055
hubertp
force-pushed
the
wip/hubert/name-resolution-all-import-183833055
branch
from
08f5afc
to
87c377d
Compare
radeusgd
approved these changes
Nov 29, 2022
JaroslavTulach
approved these changes
Nov 30, 2022
mergify
bot
deleted the
wip/hubert/name-resolution-all-import-183833055
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
It appears that when were doing
from XYZ import allthe module
XYZwas also being taken into account during name resolution.This was unfortunate and became problematic when one had a type with the same name defined in it.
During pattern matching one could not simply do
since the compiler would complain that we try to pattern match on a type but give it a module.
The module is now excluded from the name resolution, when importing everything from the module.
It appears that this "feature" was used in a number of our tests, so they had to be adapted.
This fixes task 4 in https://www.pivotaltracker.com/story/show/183833055
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide buildand./run ide watch.