-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update starts_with, ends_with and contains to new API design #4078
Conversation
Fix error handling on Data.fetch.
Add SQLite full support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
I really like the simplicity of the new API and also the fact that we now express default handling by an explicit Atom instead of Nothing
.
Just one code style suggestion - I think the locale
check should now become the responsibility of prepare_distinct
.
I'd add a test checking it and mark it pending in Postgres - so that we have it clearly documented that this feature is pending. I think it is worth keeping such 'documentation-test' as if we get some bug report in the future at least we'll be more aware that this was a conscious decision to defer this instead of being confused that it is a bug.
And I think we should be explicit that forcing case sensitivity in Postgres is currently not supported - otherwise a user may use it and be confused why it doesn't work. Especially as this workaround does not affect the default usage.
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Case_Sensitivity.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Database/0.0.0-dev/src/Data/Table.enso
Outdated
Show resolved
Hide resolved
Nothing -> | ||
Case_Sensitivity.Default -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm so fond of this change! Meaningful constructors are always much better over Nothing
carrying thousands of meanings.
distribution/lib/Standard/Database/0.0.0-dev/src/Internal/Base_Generator.enso
Outdated
Show resolved
Hide resolved
Sort default on Table.distinct.
Pull Request Description
Text.starts_with
,Text.ends_with
andText.contains
to new simpler API.Case_Sensitivity.Default
and adjustedTable.distinct
to use it by default.Data.fetch
on an HTTP error.Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide build
and./run ide watch
.