Formatter fix to not fail when encountering an invalid symlink. #6172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwu-tow
added
the
CI: No changelog needed
kazcw
approved these changes
Apr 5, 2023
kazcw
reviewed
Apr 5, 2023
build/enso-formatter/src/lib.rs
Outdated
| pub fn discover_paths_internal( | ||
| vec: &mut Vec<RustSourcePath>, | ||
| path: impl AsRef<Path>, | ||
| is_main_dir: bool, | ||
| ) -> Result { | ||
| use ide_ci::fs; | ||
| let path = path.as_ref(); | ||
| let md = fs::metadata(path)?; | ||
| // Below we use `symlink_metadata` instead of `metadata` because the latter follows symlinks. | ||
| // We don't want the formatter to fail if it encounters a symlink to a non-existing file. |
Procrat
added a commit
that referenced
this pull request
Apr 6, 2023
* develop: Project Sharing (#6077) Adjust `{Table|Column}.parse` to use `Value_Type` (#6213) Add cloud endpoints for frontend (#6002) Implement `Table.union` for Database backend (#6204) Batch insert suggestions (#6189) Formatter fix to not fail when encountering an invalid symlink. (#6172) Suspended atom fields are evaluated only once (#6151) Text.to_display_text is (shortened) identity (#6174) Engine benchmark visualization tool can compare two bench runs (#6198) Add PRIVATE so function hidden from Component Browser and other tidying... (#6207) Hotfix for #6203. (#6210)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Recently I was getting failures when running
./run fmt. This was caused by a symlink leading to a non-existent file under some of the node directories. This PR addresses this issue,Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.