-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch insert suggestions #6189
Batch insert suggestions #6189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved from the libs side.
@@ -8,6 +8,7 @@ logging-service.logger { | |||
akka.event = error | |||
akka.io = error | |||
akka.stream = error | |||
slick = error | |||
slick.jdbc.JdbcBackend.statement = error # log SQL queries on debug level |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that comment doesn't seem to reflect the state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided not to enable the debug logs for slick.jdbc.JdbcBackend.statement
by default because it produces a lot of output. I think in general, we're not interested in SQL queries unless we're debugging some specific issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense now. Just from the comment I assumed this should have been = debug
.
@@ -371,145 +371,7 @@ class SuggestionsHandlerEventsTest extends BaseServerTest with FlakySpec { | |||
{ "jsonrpc" : "2.0", | |||
"id" : 3, | |||
"result" : { | |||
"entries" : [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getSuggestionDatabase
now results in entries : []
being returned.
* @param hasDefault does the argument have the default value | ||
* @param defaultValue optional default value | ||
*/ | ||
case class ArgumentRow( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably removes removes the argument table.
* develop: Project Sharing (#6077) Adjust `{Table|Column}.parse` to use `Value_Type` (#6213) Add cloud endpoints for frontend (#6002) Implement `Table.union` for Database backend (#6204) Batch insert suggestions (#6189) Formatter fix to not fail when encountering an invalid symlink. (#6172) Suspended atom fields are evaluated only once (#6151) Text.to_display_text is (shortened) identity (#6174) Engine benchmark visualization tool can compare two bench runs (#6198) Add PRIVATE so function hidden from Component Browser and other tidying... (#6207) Hotfix for #6203. (#6210)
Pull Request Description
close #6080
Changelog
SuggestionsRepo.insertAll
as a batch SQL insertsearch/getSuggestionsDatabase
returns empty suggestions. Currently, the method is only used at startup and returns the empty response anyway because the libs are not loaded at that point.SuggestionsRepo
Important Notes
Speeds up libraries loading by ~1 second.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.