Batch insert suggestions #6189
Merged
Batch insert suggestions #6189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e6
added
the
CI: No changelog needed
4e6
requested review from
JaroslavTulach,
radeusgd,
hubertp and
jdunkerley
as code owners
jdunkerley
approved these changes
Apr 5, 2023
hubertp
approved these changes
Apr 5, 2023
| @@ -8,6 +8,7 @@ logging-service.logger { | |||
| akka.event = error | |||
| akka.io = error | |||
| akka.stream = error | |||
| slick = error | |||
| slick.jdbc.JdbcBackend.statement = error # log SQL queries on debug level | |||
There was a problem hiding this comment.
that comment doesn't seem to reflect the state?
There was a problem hiding this comment.
I decided not to enable the debug logs for slick.jdbc.JdbcBackend.statement by default because it produces a lot of output. I think in general, we're not interested in SQL queries unless we're debugging some specific issue.
There was a problem hiding this comment.
Makes sense now. Just from the comment I assumed this should have been = debug.
JaroslavTulach
approved these changes
Apr 6, 2023
| @@ -371,145 +371,7 @@ class SuggestionsHandlerEventsTest extends BaseServerTest with FlakySpec { | |||
| { "jsonrpc" : "2.0", | |||
| "id" : 3, | |||
| "result" : { | |||
| "entries" : [ | |||
There was a problem hiding this comment.
getSuggestionDatabase now results in entries : [] being returned.
| * @param hasDefault does the argument have the default value | ||
| * @param defaultValue optional default value | ||
| */ | ||
| case class ArgumentRow( |
There was a problem hiding this comment.
This probably removes removes the argument table.
Procrat
added a commit
that referenced
this pull request
Apr 6, 2023
* develop: Project Sharing (#6077) Adjust `{Table|Column}.parse` to use `Value_Type` (#6213) Add cloud endpoints for frontend (#6002) Implement `Table.union` for Database backend (#6204) Batch insert suggestions (#6189) Formatter fix to not fail when encountering an invalid symlink. (#6172) Suspended atom fields are evaluated only once (#6151) Text.to_display_text is (shortened) identity (#6174) Engine benchmark visualization tool can compare two bench runs (#6198) Add PRIVATE so function hidden from Component Browser and other tidying... (#6207) Hotfix for #6203. (#6210)
7 tasks
MichaelMauderer
pushed a commit
that referenced
this pull request
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
close #6080
Changelog
SuggestionsRepo.insertAllas a batch SQL insertsearch/getSuggestionsDatabasereturns empty suggestions. Currently, the method is only used at startup and returns the empty response anyway because the libs are not loaded at that point.SuggestionsRepoImportant Notes
Speeds up libraries loading by ~1 second.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.