-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PRIVATE so function hidden from Component Browser and other tidying... #6207
Add PRIVATE so function hidden from Component Browser and other tidying... #6207
Conversation
Sort out some `default` arguments.
Mark `to_sign` for `Sort_Direction` as PRIVATE. Add `Table.from_objects` to default group.
Add type signature to `Filter_Condition.to_predicate`. Fix failing test.
Started on Meta and HTTP.
from Standard.Base import Date_Time | ||
|
||
example_to_text = Date_Time.now.to_text | ||
to_text : Text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we generally deprecating to_text in favor of Javascript objects?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no - just no need for this built-in wrapper. The other Time types don't have it so aligned with them.
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Regex/Pattern.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Regex/Match.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Time/Date_Time.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Base/0.0.0-dev/src/Runtime/Thread.enso
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a general skim over the changes, looks good overall and I just trust the choices for changing the visibility.
…ng-visualization-helpers-for-many-types-ie-text
* develop: Project Sharing (#6077) Adjust `{Table|Column}.parse` to use `Value_Type` (#6213) Add cloud endpoints for frontend (#6002) Implement `Table.union` for Database backend (#6204) Batch insert suggestions (#6189) Formatter fix to not fail when encountering an invalid symlink. (#6172) Suspended atom fields are evaluated only once (#6151) Text.to_display_text is (shortened) identity (#6174) Engine benchmark visualization tool can compare two bench runs (#6198) Add PRIVATE so function hidden from Component Browser and other tidying... (#6207) Hotfix for #6203. (#6210)
Pull Request Description
Review the set of public functions. Mark many as PRIVATE so not in CB.
Some other small tidying.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.