Add PRIVATE so function hidden from Component Browser and other tidying... #6207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sort out some `default` arguments.
Mark `to_sign` for `Sort_Direction` as PRIVATE. Add `Table.from_objects` to default group.
Add type signature to `Filter_Condition.to_predicate`. Fix failing test.
Started on Meta and HTTP.
jdunkerley
added
the
CI: No changelog needed
GregoryTravis
approved these changes
Apr 5, 2023
| from Standard.Base import Date_Time | ||
|
|
||
| example_to_text = Date_Time.now.to_text | ||
| to_text : Text |
There was a problem hiding this comment.
Are we generally deprecating to_text in favor of Javascript objects?
There was a problem hiding this comment.
no - just no need for this built-in wrapper. The other Time types don't have it so aligned with them.
radeusgd
reviewed
Apr 5, 2023
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Regex/Pattern.enso
Outdated
Show resolved
Hide resolved
radeusgd
reviewed
Apr 5, 2023
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Regex/Match.enso
Outdated
Show resolved
Hide resolved
radeusgd
reviewed
Apr 5, 2023
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Time/Date_Time.enso
Outdated
Show resolved
Hide resolved
radeusgd
reviewed
Apr 5, 2023
distribution/lib/Standard/Base/0.0.0-dev/src/Runtime/Thread.enso
Outdated
Show resolved
Hide resolved
radeusgd
approved these changes
Apr 5, 2023
…ng-visualization-helpers-for-many-types-ie-text
mergify
bot
deleted the
wip/jd/6047-component-browser-is-suggesting-visualization-helpers-for-many-types-ie-text
branch
Procrat
added a commit
that referenced
this pull request
Apr 6, 2023
* develop: Project Sharing (#6077) Adjust `{Table|Column}.parse` to use `Value_Type` (#6213) Add cloud endpoints for frontend (#6002) Implement `Table.union` for Database backend (#6204) Batch insert suggestions (#6189) Formatter fix to not fail when encountering an invalid symlink. (#6172) Suspended atom fields are evaluated only once (#6151) Text.to_display_text is (shortened) identity (#6174) Engine benchmark visualization tool can compare two bench runs (#6198) Add PRIVATE so function hidden from Component Browser and other tidying... (#6207) Hotfix for #6203. (#6210)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Review the set of public functions. Mark many as PRIVATE so not in CB.
Some other small tidying.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.