-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #5075: stop panning on full-screen visualisation #6530
Merged
mergify
merged 4 commits into
develop
from
wip/procrat/fix-panning-on-fullscreen-viz-5075
May 5, 2023
Merged
Fix #5075: stop panning on full-screen visualisation #6530
mergify
merged 4 commits into
develop
from
wip/procrat/fix-panning-on-fullscreen-viz-5075
May 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Procrat
force-pushed
the
wip/procrat/fix-panning-on-fullscreen-viz-5075
branch
from
May 3, 2023 12:04
1f3d386
to
6d4fc59
Compare
Procrat
requested review from
MichaelMauderer,
wdanilo,
farmaazon and
kazcw
as code owners
May 3, 2023 12:04
wdanilo
approved these changes
May 3, 2023
QA: 🟢 |
…-5075 * develop: Build nightly 3 hours earlier. (#6551) Cache result of slow function resolution on Any that is present on a hot path (#6536) Fix cut-off in text visualisations (#6421) Infer correct synthetic name for nested modules (#6525) Delete unused websocket dependency (#6535) Run typecheck and eslint on `./run lint` (#6314) Force pending saves if client closes abruptly (#6514)
@sylwiabr i think it was partly because i committed something that broke the lint CI - it should be fixed now so adding the |
there are other lints that seem to be failing as well, not sure what the cause is though |
somebody1234
added
the
CI: Keep up to date
Automatically update this PR to the latest develop.
label
May 5, 2023
Procrat
added a commit
that referenced
this pull request
May 10, 2023
* develop: (28 commits) Add tests for Date.until, Date.next and Date.previous. (#6606) Improve `Non_Unique_Primary_Key` error, split file format detection into read/write, improve SQLite format detection (#6604) tokenize_to_columns or parse_to_columns results in a single column we shouldn't add the 1 (#6607) Fix node editing race condition (#6594) Add format to the in-memory Column (#6538) Fix dashboard issues (part 2) (#6511) Fix visualisation type selector artifacts rendered after node preview visualisation was closed. (#6575) Revert typescript CI Lint changes (#6602) Fix the Engine version check in GUI (#6570) Show error pop-up when failing to rename a project (#6366) Small changes from Book Club issues (#6533) "at_least_one" flag for tokenize_to_rows (#6539) Benchmark Engine job runs only engine, not Enso benchmarks (#6534) Catch 5813 and avoid crash (#6585) Fix opening links in desktop IDE (#6507) Identify SyntaxError exception and avoid printing a stack trace (#6574) Fix dashboard issues (#6502) Let ChangesetBuilder.invalidated search even container elements (#6548) Fix #5075: stop panning on full-screen visualisation (#6530) Only `Join_Kind.Inner` removes the common-named columns (#6564) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI: Keep up to date
Automatically update this PR to the latest develop.
CI: Ready to merge
This PR is eligible for automatic merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #5075: dragging or scrolling while a visualisation is in full screen caused the camera to move in the graph editor.
The problem was that clicking on the visualisation triggered some FRP node that indicated that the project list should be closed, which then indicated that the navigator shouldn't be disabled. However, the FRP code in the graph editor interpreted "shouldn't be disabled" as "should be enabled", ignoring the fact that there's also a full-screen visualisation, which should always disable the navigator.
fix-fullscreen-viz-panning.mp4
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Unit tests have been written where possible../run ide build
.