Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only Join_Kind.Inner removes the common-named columns #6564

Merged
merged 2 commits into from
May 5, 2023

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented May 4, 2023

Pull Request Description

As requested by @jdunkerley

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@radeusgd radeusgd added the CI: No changelog needed Do not require a changelog entry for this PR. label May 4, 2023
@radeusgd radeusgd self-assigned this May 4, 2023
@radeusgd radeusgd changed the base branch from develop to wip/5777-aws-s3-read May 4, 2023 16:27
@radeusgd radeusgd force-pushed the wip/radeusgd/only-inner-removes-common-column branch from 2e12064 to 10c4a69 Compare May 4, 2023 16:39
Base automatically changed from wip/5777-aws-s3-read to develop May 4, 2023 17:36
@radeusgd radeusgd force-pushed the wip/radeusgd/only-inner-removes-common-column branch from 10c4a69 to 6af4a12 Compare May 4, 2023 17:39
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label May 4, 2023
@mergify mergify bot merged commit 0be572a into develop May 5, 2023
@mergify mergify bot deleted the wip/radeusgd/only-inner-removes-common-column branch May 5, 2023 08:12
Procrat added a commit that referenced this pull request May 10, 2023
* develop: (28 commits)
  Add tests for Date.until, Date.next and Date.previous. (#6606)
  Improve `Non_Unique_Primary_Key` error, split file format detection into read/write, improve SQLite format detection (#6604)
  tokenize_to_columns or parse_to_columns results in a single column we shouldn't add the  1 (#6607)
  Fix node editing race condition (#6594)
  Add format to the in-memory Column (#6538)
  Fix dashboard issues (part 2) (#6511)
  Fix visualisation type selector artifacts rendered after node preview visualisation was closed. (#6575)
  Revert typescript CI Lint changes (#6602)
  Fix the Engine version check in GUI (#6570)
  Show error pop-up when failing to rename a project (#6366)
  Small changes from Book Club issues (#6533)
  "at_least_one" flag for tokenize_to_rows (#6539)
  Benchmark Engine job runs only engine, not Enso benchmarks (#6534)
  Catch 5813 and avoid crash (#6585)
  Fix opening links in desktop IDE (#6507)
  Identify SyntaxError exception and avoid printing a stack trace (#6574)
  Fix dashboard issues (#6502)
  Let ChangesetBuilder.invalidated search even container elements (#6548)
  Fix #5075: stop panning on full-screen visualisation (#6530)
  Only `Join_Kind.Inner` removes the common-named columns (#6564)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants