Fix #6521: Main module function calls shouldn't use project namespace #6719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Procrat
force-pushed
the
wip/procrat/fix-func-generation-on-project-rename
branch
from
876f0bb
to
f95e306
Compare
Procrat
requested review from
MichaelMauderer,
wdanilo,
farmaazon,
mwu-tow and
kazcw
as code owners
farmaazon
requested changes
May 17, 2023
| @@ -432,7 +432,7 @@ impl Entry { | |||
|
|
|||
| fn code_with_static_this(&self) -> String { | |||
| if let Some(self_type) = &self.self_type { | |||
| format!("{}{}{}", self_type.alias_name(), opr::predefined::ACCESS, self.name) | |||
| format!("{}{}{}", self_type.name(), opr::predefined::ACCESS, self.name) | |||
There was a problem hiding this comment.
Unfortunately, it won't work with methods from Main modules of other projects. We need to check if the entry is actually from a currently opened project.
There was a problem hiding this comment.
Good catch. I've changed it. Do you want to have another look?
…t-rename * develop: Widgets, Vector as Column, Viz Fixes and Rename Columns (#6768) Implement simple variants of `parse` for the Database backend (#6731) Enable `require-jsdoc` lint and add two lints related to React (#6403) Decimal/Integer .round and .int #6654 (#6743) Set suggestion reexports when serializing the library (#6778) Fix file uploading node expression. (#6689) Using WarningsLibrary to query for warnings (#6751) Implement `cast` for Table and Column (#6711) Display Initializing project... message when initializing project (#6661) Only send suggestions updates when type changes (#6755) sbt runEngineDistribution --debug to ease debuggging (#6745) Display "modified at" column on the cloud dashboard (#6687) Meta.meta Integer . methods (#6740) Show spinner while loading directory (#6714) Add cloud dashboard to changelog (#6688) Fix list editor panics during insertion (#6540) Update bug-report.yml Remove project create form (#6710) Change full-screen visualisation shortcut to shift-space (#6663)
farmaazon
approved these changes
May 22, 2023
app/gui/src/controller/searcher.rs
Outdated
Comment on lines
397
to
398
| /// The name of the currently active module. | ||
| module_name: Rc<QualifiedName>, |
There was a problem hiding this comment.
Please add a short info why module_name affects the filtering, perhaps with reference to update_matching_info or code_with_static_this.
@farmaazon: You were right, it was adding that import. Care to have another look before we move on to QA? |
farmaazon
approved these changes
May 22, 2023
|
🟢 QA passed |
Procrat
added a commit
that referenced
this pull request
May 23, 2023
* develop: Link to new 101 tutorial and not deprecated one. (#6793) Add logs section to the bug template (#6798) Fix #6521: Main module function calls shouldn't use project namespace (#6719) Add project creation time to project metadata (#6780) Add a compiler pass to analyze non-existing imported symbols (#6726)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #6521: Picking a function from the CB that's defined in the main module now resolves to
Main.<func-name>instead of<project-name>.<func-name>.Note that, when collapsing nodes to a function, this referral style was already used, so this is just a change in the behaviour of the CB.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred../run ide build.