Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decimal/Integer .round and .int #6654 #6743

Merged
merged 49 commits into from
May 19, 2023
Merged

Decimal/Integer .round and .int #6654 #6743

merged 49 commits into from
May 19, 2023

Conversation

GregoryTravis
Copy link
Contributor

@GregoryTravis GregoryTravis commented May 17, 2023 •
edited
Loading

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@GregoryTravis
slow and tests
0d41f11
@GregoryTravis
slow impl tests pass
f64ea73
@GregoryTravis
tests pass with builtin
3c8a3e9
@GregoryTravis
even worse
eed65d9
@GregoryTravis
Merge branch 'develop' into wip/gmt/5194-rounding
7c889a4
@GregoryTravis
revert floor
11200ea
@GregoryTravis
revert precision test
20c1906
@GregoryTravis
cleanup
0fd0f47
@GregoryTravis
overload
57208b5
@GregoryTravis
dp out of range
91aedd1
@GregoryTravis
Implicit dp=0
20a1620
@GregoryTravis
magically calling integer node
e8cd675
@GregoryTravis
Merge branch 'develop' into wip/gmt/5194-rounding
6cd8b76
@GregoryTravis
integer round in enso
2bbcef3
@GregoryTravis
more tests
4851b3b
@GregoryTravis
.int, cannot find truffle node
928514c
@GregoryTravis
still cannot find it
c229450
@GregoryTravis
int
badc9df
@GregoryTravis
still going through double
a579041
@GregoryTravis
new builtins
a0a0e9d
@GregoryTravis
builds
bc6f685
@GregoryTravis
two-step scaling, not asymmetric
6817024
@GregoryTravis
simple
9ae6d24
@GregoryTravis
bankers
4f54601
@GregoryTravis
bankers bug
a652fad
@GregoryTravis
unnecessary .int
68f3756
@GregoryTravis
large doubles
ec216a9
@GregoryTravis
limit int round range
0370644
@GregoryTravis
special values
43f41d2
@GregoryTravis
near max long
b2d8b88
@jdunkerley
Copy link
Member

jdunkerley commented May 18, 2023 •
edited
Loading

@radeusgd raised whether we should call it int or truncate.
Excel uses both int and trunc these days.

I'd like to do a quick scan but I think it has become more common (and SQL uses it), so lets rename it to truncate.

@GregoryTravis GregoryTravis linked an issue May 18, 2023 that may be closed by this pull request
Design and implement rounding functions #5194
Closed
@GregoryTravis GregoryTravis added the CI: Ready to merge This PR is eligible for automatic merge label May 19, 2023
@mergify mergify bot merged commit 4f71673 into develop May 19, 2023
@mergify mergify bot deleted the wip/gmt/5194-rounding branch May 19, 2023 19:23
Procrat added a commit that referenced this pull request May 22, 2023
@Procrat
Merge branch 'develop' into wip/procrat/fix-func-generation-on-projec…
0e9da81 
…t-rename

* develop:
  Widgets, Vector as Column, Viz Fixes and Rename Columns (#6768)
  Implement simple variants of `parse` for the Database backend (#6731)
  Enable `require-jsdoc` lint and add two lints related to React (#6403)
  Decimal/Integer .round and .int #6654 (#6743)
  Set suggestion reexports when serializing the library (#6778)
  Fix file uploading node expression. (#6689)
  Using WarningsLibrary to query for warnings (#6751)
  Implement `cast` for Table and Column (#6711)
  Display Initializing project... message when initializing project (#6661)
  Only send suggestions updates when type changes (#6755)
  sbt runEngineDistribution --debug to ease debuggging (#6745)
  Display "modified at" column on the cloud dashboard (#6687)
  Meta.meta Integer . methods (#6740)
  Show spinner while loading directory (#6714)
  Add cloud dashboard to changelog (#6688)
  Fix list editor panics during insertion (#6540)
  Update bug-report.yml
  Remove project create form (#6710)
  Change full-screen visualisation shortcut to shift-space (#6663)
Procrat added a commit that referenced this pull request May 22, 2023
@Procrat
Merge branch 'develop' into wip/procrat/home-button-6399
46418f1 
* develop: (30 commits)
  Widgets, Vector as Column, Viz Fixes and Rename Columns (#6768)
  Implement simple variants of `parse` for the Database backend (#6731)
  Enable `require-jsdoc` lint and add two lints related to React (#6403)
  Decimal/Integer .round and .int #6654 (#6743)
  Set suggestion reexports when serializing the library (#6778)
  Fix file uploading node expression. (#6689)
  Using WarningsLibrary to query for warnings (#6751)
  Implement `cast` for Table and Column (#6711)
  Display Initializing project... message when initializing project (#6661)
  Only send suggestions updates when type changes (#6755)
  sbt runEngineDistribution --debug to ease debuggging (#6745)
  Display "modified at" column on the cloud dashboard (#6687)
  Meta.meta Integer . methods (#6740)
  Show spinner while loading directory (#6714)
  Add cloud dashboard to changelog (#6688)
  Fix list editor panics during insertion (#6540)
  Update bug-report.yml
  Remove project create form (#6710)
  Change full-screen visualisation shortcut to shift-space (#6663)
  Revert "Show spinner when opening/creating a project (#6321)" (#6712)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaroslavTulach JaroslavTulach JaroslavTulach approved these changes

@Akirathan Akirathan Akirathan approved these changes

@jdunkerley jdunkerley jdunkerley approved these changes

@radeusgd radeusgd radeusgd approved these changes

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

Assignees
No one assigned
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Design and implement rounding functions
5 participants
@GregoryTravis @jdunkerley @radeusgd @Akirathan @JaroslavTulach