Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use autoscoping when constructing tag values of suggestion arguments #9259

Closed
4e6 opened this issue Mar 4, 2024 · 5 comments · Fixed by #9293
Closed

Use autoscoping when constructing tag values of suggestion arguments #9259

4e6 opened this issue Mar 4, 2024 · 5 comments · Fixed by #9293
Assignees

Comments

@4e6
Copy link
Contributor

4e6 commented Mar 4, 2024

When the argument has an ascribed type its tag values should use the autoscoped constructors feature. If there is a method:

type Counting
    Zero
    One
    Two 
    Many n:Integer

next c:Counting = case c of
   Counting.Zero -> Counting.One
   Counting.Two -> Counting.Many 3
   Counting.Many n -> Counting.Many n+1

then the tagValues for c argument of next method should be ~Zero, ~One, ~Two and ~Many rather than Counting.Zero & co.

@4e6 4e6 self-assigned this Mar 4, 2024
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Mar 4, 2024
This was referenced Mar 4, 2024
@4e6 4e6 moved this from ❓New to 📤 Backlog in Issues Board Mar 4, 2024
@radeusgd
Copy link
Member

radeusgd commented Mar 4, 2024

Given the problems when we have aliasing constructors in a sum type, could we make it so that the shorthand autoscoped form is only suggested if the constructors are all distinct? Or would it be too complicated to check what the constructors are when generating the suggestions?

@4e6 4e6 moved this from 📤 Backlog to 🔧 Implementation in Issues Board Mar 5, 2024
@enso-bot
Copy link

enso-bot bot commented Mar 6, 2024

Dmitry Bushev reports a new STANDUP for yesterday (2024-03-05):

Progress: Started working on the task. Updated the tag values creation logic to use the autoscope syntax. Added tests. Created draft PR. Fixed some of the flaky visualization tests. Created PR It should be finished by 2024-03-08.

Next Day: Next day I will be working on the #9259 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented Mar 6, 2024

Dmitry Bushev reports a new STANDUP for today (2024-03-06):

Progress: Continue working on the task. Updated the tag values logic to use the autoscope syntax when there is a type ascription in addition to a separate type definition. Tested in gui. Undrafted the PR. More work on the flaky visualization tests. It should be finished by 2024-03-08.

Next Day: Next day I will be working on the #9259 task. Continue working on the task

@4e6 4e6 moved this from 🔧 Implementation to 👁️ Code review in Issues Board Mar 7, 2024
@enso-bot
Copy link

enso-bot bot commented Mar 9, 2024

Dmitry Bushev reports a new STANDUP for yesterday (2024-03-08):

Progress: Returned to the task. Updated the PR adding the filesystem commands to the project manager. Added path resolution. Merged the PR. Updated and merged the PR fixing the warnings preview. Was checking how the autoscoping interacts with dynamic widgets in the gui. It should be finished by 2024-03-08.

Next Day: Next day I will be working on the #9259 task. Continue working on the task

@JaroslavTulach
Copy link
Member

Is this waiting for resolution of

@4e6 4e6 closed this as completed in #9293 Apr 8, 2024
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants