Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show progress of buildNativeImage #9276

Merged
merged 6 commits into from
Mar 6, 2024
Merged

Show progress of buildNativeImage #9276

merged 6 commits into from
Mar 6, 2024

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Mar 5, 2024 •
edited
Loading

Pull Request Description

Printing out buildNativeImage progress as soon as possible. In case of failure dumping it again as a whole.

  • All code follows the
    Scala,
    style guides.
  • All code has been tested:
    • Manually verified the log is printed

@JaroslavTulach JaroslavTulach self-assigned this Mar 5, 2024
Akirathan
Akirathan approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@Akirathan Akirathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This will help us detect if the native image build process hangs.

@Akirathan Akirathan added the CI: No changelog needed Do not require a changelog entry for this PR. label Mar 5, 2024
@JaroslavTulach JaroslavTulach added the CI: Ready to merge This PR is eligible for automatic merge label Mar 5, 2024
@enso-bot enso-bot bot mentioned this pull request Mar 6, 2024
Closed
@JaroslavTulach JaroslavTulach added CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: Keep up to date Automatically update this PR to the latest develop. labels Mar 6, 2024
@JaroslavTulach
Copy link
Member Author

I am adding keep up to date as there was a persistent failure in Vue tests - e.g. something completely unrelated to this change and I am tired of re-triggering the build manually. CCing @mwu-tow.

@JaroslavTulach JaroslavTulach removed the CI: Keep up to date Automatically update this PR to the latest develop. label Mar 6, 2024
@mwu-tow
Copy link
Contributor

mwu-tow commented Mar 6, 2024

I am adding keep up to date as there was a persistent failure in Vue tests - e.g. something completely unrelated to this change and I am tired of re-triggering the build manually. CCing @mwu-tow.

Thank you for letting me know. This is tracked as part of https://github.com/enso-org/cloud-v2/issues/916

@mwu-tow
Copy link
Contributor

mwu-tow commented Mar 6, 2024

Poking the CLA bot.

@mergify mergify bot merged commit c5e4173 into develop Mar 6, 2024
27 of 29 checks passed
@mergify mergify bot deleted the wip/jtulach/LogNativeImageProgress branch March 6, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubertp hubertp hubertp approved these changes

@Akirathan Akirathan Akirathan approved these changes

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JaroslavTulach @mwu-tow @hubertp @Akirathan