Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging edges #9788

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Dragging edges #9788

merged 4 commits into from
Apr 29, 2024

Conversation

farmaazon
Copy link
Contributor

Pull Request Description

Fixes #9423

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@farmaazon farmaazon added CI: No changelog needed Do not require a changelog entry for this PR. x-new-feature Type: new feature request -gui labels Apr 25, 2024
@farmaazon farmaazon self-assigned this Apr 25, 2024
@@ -200,3 +200,5 @@ export function useDragging() {
},
}
}

function useEdgeDragging() {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A leftover, to be removed.

@farmaazon farmaazon added the CI: Ready to merge This PR is eligible for automatic merge label Apr 29, 2024
@mergify mergify bot merged commit 04a10b7 into develop Apr 29, 2024
37 checks passed
@mergify mergify bot deleted the wip/farmaazon/dragging-edges branch April 29, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge x-new-feature Type: new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drag and release from an output port should add a new component
2 participants