Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File.vue' action icons showing for Documents when no permissions #17

Closed
jlsjonas opened this issue May 27, 2019 · 0 comments
Closed

File.vue' action icons showing for Documents when no permissions #17

jlsjonas opened this issue May 27, 2019 · 0 comments
Assignees
@aocneanu

Comments

@jlsjonas
Copy link
Contributor

jlsjonas commented May 27, 2019 •
edited
Loading

This is a bug.
ref: laravel-enso/documents#12

Prerequisites

yes

Description

The change introduced in 918b45c doesn't affect the ref'd issue as it's calling core.documents.destroy, not core.files.destroy.
the File.vue component is used unless the compact parameter is passed to Documents.vue
image

The same goes for the other actions

Steps to Reproduce

  1. user without core.documents.destroy permission
  2. upload a document & try to destroy it

Expected behavior

icon to be hidden

Actual behavior

hidden error, broken UX
@jlsjonas jlsjonas changed the title Documents destroy icon still showing when no permissions File.vue' action icons showing for Documents when no permissions May 27, 2019
@aocneanu aocneanu self-assigned this May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aocneanu aocneanu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlsjonas @aocneanu