Fix split editor area pane focus #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 20, 2013 14:58
…abs. If an editor contains tabs, after certain operations (e.g., navigating the editor tabs using keyboard shortcuts) a change in focus sets the editor area pane `active_tabwidget` to one of those internal tabs, rather than to the tab of the editor in the editor area.
|
@agrawalprash @pankajp Hopefully, I got your intention right here... Could you please review and see if the fix makes sense? I'm still a bit insecure when it comes to having multiple splits. |
|
|
||
|
|
||
| @contextmanager | ||
| def event_loop(): |
There was a problem hiding this comment.
Can you please either rename this to event_loop_qt or move it to ui.qt4.utils? Thanks.
|
@pberkes Thanks for catching this case and fixing it. And thanks for PEP8'ing it. Apart from a minor comment, this looks good to me. |
|
@agrawalprash I moved the qt-specific testing utils to |
agrawalprash
added a commit
that referenced
this pull request
Jun 21, 2013
Fix split editor area pane focus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an editor contains tabs, after certain operations (e.g., navigating
the editor tabs using keyboard shortcuts) a change in focus
sets the editor area pane
active_tabwidgetto one of those internal tabs,rather than to the tab of the editor in the editor area.
This causes problems, e.g. in this example I added two editors, and one got inserted inside the other: