Address a Qt DeprecationWarning and ResourceWarnings #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by replacing the deprecated font_metrics.width method with the recommended font_metrics.horizontalAdvance method and by properly closing temporary files that a test had created/opened modified: pyface/ui/qt4/console/console_widget.py modified: pyface/ui/qt4/tasks/tests/test_split_editor_area_pane.py
…tion-resource-warnings
aaronayres35
approved these changes
Jul 1, 2021
I first noticed them when I ran the testsuite on Python 3.8 - not Python 3.6 that we use by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a specific Qt
DeprecationWarning- replacing the deprecatedfont_metrics.widthmethod with therecommended
font_metrics.horizontalAdvancemethod. This PR also fixesResourceWarnings by properly closing temporary files that a test had created/opened.Ref https://doc.qt.io/qt-5/qfontmetrics-obsolete.html#width and https://doc.qt.io/qt-5/qfontmetrics.html#horizontalAdvance