Update new test_editor_error_msg #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#1551 is not occurring which is a good sign! Doesn't guarantee it is resolved though as it did not occur on every run in 1546 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #1551
The intermittent test failure first appeared in pr #1546, and after my realization on #1540 I am suspect of
auto_process_eventson UITester being relevant here as well (although this is still more of a hunch than a well understood solution). This PR sets auto_process_events=False (the test still runs as expected with ModalDialogTester taking the full event processing responsibility, so even if this was not the cause of 1551 this change is still viable).In addition, looking back at the test from 1546 and looking more closely at the code in ModalDialogTester, I realize that the
textarg inhas_widgetcorresponds to the text the widget holds which is the same value regardless of the format (it was not corresponding to the text actually displayed by the widget) so the previous test wasn't really hitting the core issue. I added an assert statement explicitly checking thetextFormatmatches what it was set to.