Add 'IsVisible` query class for UI Tester #1552

aaronayres35 · 2021-03-24T15:25:10Z

Now that #1490 has been merged this process was quite simple :)

This PR makes it so that now any UIWrapper object wrapping a target with a control that is either a QtWidget or wx.Window can now support an IsVisible query. A comparable thing was done for IsEnabled in 1490.

This PR also updates the relevant tests for _control_widget_registry and adds a test for the visible_when.py demo.

…sts accordingly

aaronayres35 · 2021-03-24T15:41:41Z

#1551 has returned! this time with full traceback

test_base_url_changed (traitsui.tests.editors.test_html_editor.TestHTMLEditor) ... Fatal Python error: Illegal instruction

Current thread 0x00007feb44de9740 (most recent call first):
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/site-packages/traitsui/testing/_gui.py", line 36 in process_cascade_events
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/site-packages/traitsui/testing/tester/ui_tester.py", line 116 in create_ui
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/contextlib.py", line 88 in __exit__
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/site-packages/traitsui/tests/editors/test_html_editor.py", line 253 in test_base_url_changed
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/unittest/case.py", line 605 in run
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/unittest/case.py", line 653 in __call__
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/unittest/suite.py", line 122 in run
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/unittest/suite.py", line 84 in __call__
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/unittest/suite.py", line 122 in run
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/unittest/suite.py", line 84 in __call__
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/unittest/suite.py", line 122 in run
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/unittest/suite.py", line 84 in __call__
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/unittest/suite.py", line 122 in run
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/unittest/suite.py", line 84 in __call__
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/unittest/runner.py", line 176 in run
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/unittest/main.py", line 256 in runTests
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/unittest/main.py", line 95 in __init__
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/unittest/__main__.py", line 18 in <module>
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/site-packages/coverage/execfile.py", line 183 in run_python_file
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/site-packages/coverage/execfile.py", line 113 in run_python_module
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/site-packages/coverage/cmdline.py", line 627 in do_run
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/site-packages/coverage/cmdline.py", line 483 in command_line
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/site-packages/coverage/cmdline.py", line 756 in main
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/site-packages/coverage/__main__.py", line 8 in <module>
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/runpy.py", line 85 in _run_code
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/runpy.py", line 193 in _run_module_as_main
Command '['edm', 'run', '-e', 'traitsui-test-3.6-pyside2', '--', 'python', '-X', 'faulthandler', '-W', 'default', '-m', 'coverage', 'run', '-p', '-m', 'unittest', 'discover', '-v', 'traitsui']' returned non-zero exit status 252.
/usr/bin/bash /home/runner/work/_actions/GabrielBB/xvfb-action/v1/cleanup.sh
Killing the following xvfb processes: 4894
Error: The process '/usr/bin/xvfb-run' failed with exit code 1

aaronayres35 · 2021-03-25T12:51:21Z

It looks like #1553 may have been successful, no longer seeing 1551 failure

rahulporuri

LGTM

traitsui/testing/tester/_ui_tester_registry/qt4/_control_widget_registry.py

traitsui/testing/tester/_ui_tester_registry/wx/tests/test_control_widget_registry.py

jwiggins

LGTM

Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>

…/traitsui into UITester-add-IsVisible

aaronayres35 · 2021-03-26T12:15:19Z

Looks like another occurrence of #1551

test_base_url_changed (traitsui.tests.editors.test_html_editor.TestHTMLEditor) ... Fatal Python error: Illegal instruction

Current thread 0x00007f0f6474c740 (most recent call first):
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/site-packages/traitsui/testing/_gui.py", line 36 in process_cascade_events
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/site-packages/traitsui/testing/tester/ui_tester.py", line 116 in create_ui
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/contextlib.py", line 88 in __exit__
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/site-packages/traitsui/tests/editors/test_html_editor.py", line 253 in test_base_url_changed
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/unittest/case.py", line 605 in run
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/unittest/case.py", line 653 in __call__
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/unittest/suite.py", line 122 in run
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/unittest/suite.py", line 84 in __call__
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/unittest/suite.py", line 122 in run
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/unittest/suite.py", line 84 in __call__
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/unittest/suite.py", line 122 in run
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/unittest/suite.py", line 84 in __call__
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/unittest/suite.py", line 122 in run
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/unittest/suite.py", line 84 in __call__
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/unittest/runner.py", line 176 in run
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/unittest/main.py", line 256 in runTests
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/unittest/main.py", line 95 in __init__
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/unittest/__main__.py", line 18 in <module>
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/site-packages/coverage/execfile.py", line 183 in run_python_file
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/site-packages/coverage/execfile.py", line 113 in run_python_module
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/site-packages/coverage/cmdline.py", line 627 in do_run
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/site-packages/coverage/cmdline.py", line 483 in command_line
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/site-packages/coverage/cmdline.py", line 756 in main
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/site-packages/coverage/__main__.py", line 8 in <module>
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/runpy.py", line 85 in _run_code
  File "/home/runner/work/traitsui/traitsui/.edm/envs/traitsui-test-3.6-pyside2/lib/python3.6/runpy.py", line 193 in _run_module_as_main
Command '['edm', 'run', '-e', 'traitsui-test-3.6-pyside2', '--', 'python', '-X', 'faulthandler', '-W', 'default', '-m', 'coverage', 'run', '-p', '-m', 'unittest', 'discover', '-v', 'traitsui']' returned non-zero exit status 252.
/usr/bin/bash /home/runner/work/_actions/GabrielBB/xvfb-action/v1/cleanup.sh
No xvfb processes to kill
Error: The process '/usr/bin/xvfb-run' failed with exit code 1

aaronayres35 added 4 commits March 24, 2021 09:44

add an IsVisible query class and include it in api

3073df8

add support IsVisible query to _control_widget_registry and update te…

f4617bb

…sts accordingly

add a test for the visible_when example

c2e6e17

flake8/rename test correctly

f51c9cd

Merge branch 'master' into UITester-add-IsVisible

d173187

aaronayres35 requested a review from rahulporuri March 25, 2021 13:12

aaronayres35 mentioned this pull request Mar 25, 2021

Make Scrollable group respect visible_when #1555

Merged

aaronayres35 requested a review from jwiggins March 25, 2021 21:48

rahulporuri approved these changes Mar 26, 2021

View reviewed changes

jwiggins approved these changes Mar 26, 2021

View reviewed changes

aaronayres35 and others added 5 commits March 26, 2021 04:50

Apply suggestions from code review

a59ea1a

Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>

add is invisible wx test

4eb44fe

Merge branch 'UITester-add-IsVisible' of https://github.com/enthought…

06fa49c

…/traitsui into UITester-add-IsVisible

rename test

5606b76

Merge branch 'master' into UITester-add-IsVisible

6b85e5e

aaronayres35 merged commit 8d278b3 into master Mar 26, 2021

aaronayres35 deleted the UITester-add-IsVisible branch March 26, 2021 12:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add 'IsVisible` query class for UI Tester #1552

Add 'IsVisible` query class for UI Tester #1552

aaronayres35 commented Mar 24, 2021

aaronayres35 commented Mar 24, 2021

aaronayres35 commented Mar 25, 2021

rahulporuri left a comment

jwiggins left a comment

aaronayres35 commented Mar 26, 2021

Add 'IsVisible` query class for UI Tester #1552

Add 'IsVisible` query class for UI Tester #1552

Conversation

aaronayres35 commented Mar 24, 2021

aaronayres35 commented Mar 24, 2021

aaronayres35 commented Mar 25, 2021

rahulporuri left a comment

Choose a reason for hiding this comment

jwiggins left a comment

Choose a reason for hiding this comment

aaronayres35 commented Mar 26, 2021