Make Scrollable group respect visible_when #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronayres35
changed the title
rahulporuri
approved these changes
Mar 26, 2021
There was a problem hiding this comment.
LGTM. That was quick :D. I tested this fix with the code in #1512 and it works as expected now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR sits on top of #1552 as it uses
IsVisibleto write a regression test. 1552 should be merged first, and any changes from PR review suggestions should be merged in here.Currently the diff on this PR is ugly as a result. The only relevant files being changed here are
traitsui/qt4/ui_panel.pyandtraitsui/qt4/tests/test_ui_panel.py.fixes #1512
The problem code was setting up an editor to hook up the
enabled_whenandvisible_whenchecks for the group using the control for the contained widget. In reality, if we had a scrollable group, we want these to get hooked up for the QScrollArea containing that widget not just the widget itself. Simply moving the conditional for handling scrollable groups before handling the group's enabled/visible when checks solves this problem.