Document entries parameter not supported qt for FileEditor/DirectoryEditor
#1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulporuri
approved these changes
Mar 26, 2021
I've opened #1558 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1530
Although we may want to have another issue open for adding qt support
This PR simply aims to better document the fact that the
entriesparameter for keeping a history of past entries on the FileEditor (and subsequently the DirectoryEditor) is only supported on the wx backend, but not on qt.In addition, this PR makes a fix (similar to the one made in #1067) to fix the
History_demo.pyon wx. Now if one runs the demo in an environment with wx they can see what the history functionality is actually capable of.