Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the ALIGN_CENTRE_VERTICAL FLAG to avoid error #1067

Merged
merged 6 commits into from
Jul 30, 2020
Merged

remove the ALIGN_CENTRE_VERTICAL FLAG to avoid error #1067

merged 6 commits into from
Jul 30, 2020

Conversation

aaronayres35
Copy link
Contributor

This gets rid of the

wx._core.wxAssertionError: C++ assertion "!(flags & (wxALIGN_BOTTOM | wxALIGN_CENTRE_VERTICAL))" failed at /Users/robind/projects/bb2/dist-osx-py36/build/ext/wxWidgets/src/common/sizer.cpp(2114) in DoInsert(): Vertical alignment flags are ignored with wxEXPAND

error mentioned in issue #1066 (another example of #828). However, after this fix is completed, the issue of a segfault on mouseover as mentioned in #434 still occurs.

@rahulporuri rahulporuri self-requested a review July 27, 2020 17:38
@aaronayres35 aaronayres35 mentioned this pull request Jul 29, 2020
Closed
@kitchoi kitchoi mentioned this pull request Jul 30, 2020
Merged
@kitchoi
Copy link
Contributor

kitchoi commented Jul 30, 2020

Thanks for the fix @aaronayres35! Nice catch.
I opened #1089 to add a test that reproduces the bug, this does two things: (1) confirm the change here fixes the issue (2) prevent the issue from happening again.
Could you please review and see if it can be merged to this PR?

kitchoi
kitchoi approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@kitchoi kitchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@aaronayres35 aaronayres35 merged commit 57fd3a6 into master Jul 30, 2020
@aaronayres35 aaronayres35 deleted the fix-scrubber-editor-demo branch July 30, 2020 17:53
@aaronayres35 aaronayres35 mentioned this pull request Mar 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitchoi kitchoi kitchoi approved these changes

@rahulporuri rahulporuri Awaiting requested review from rahulporuri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aaronayres35 @kitchoi