Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Specification of Base Branch #80

Merged
merged 2 commits into from
Dec 28, 2020
Merged

Allow Specification of Base Branch #80

merged 2 commits into from
Dec 28, 2020

Conversation

johnsyweb
Copy link
Contributor

Context

There are two reasons for this PR.

  1. It is becoming more common for the default branch of a repository to be named 'main'.
  2. sobanakram@b8bea1d shows that the current branch is likely to be a preference for the base branch.

Change

Add a base branch option to all commands and only check out that branch if it's specified.

Considerations

This is a change of behaviour but since this is a pre-release, I think that's OK.

@johnsyweb johnsyweb requested a review from orien December 27, 2020 05:55
joesustaric
joesustaric approved these changes Dec 27, 2020
View reviewed changes
Copy link
Contributor

@joesustaric joesustaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good pick up!

@johnsyweb johnsyweb mentioned this pull request Dec 28, 2020
Merged
orien
orien approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@orien orien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

lib/unwrappr/git_command_runner.rb Show resolved Hide resolved
@johnsyweb johnsyweb merged commit f9046a8 into master Dec 28, 2020
@johnsyweb johnsyweb deleted the paj/allow-specification-of-base-branch branch December 28, 2020 04:17
@johnsyweb johnsyweb mentioned this pull request Dec 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joesustaric joesustaric joesustaric approved these changes

@orien orien orien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnsyweb @joesustaric @orien