Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename methods with side effects #82

Merged
merged 5 commits into from
Dec 28, 2020
Merged

Rename methods with side effects #82

merged 5 commits into from
Dec 28, 2020

Conversation

johnsyweb
Copy link
Contributor

Context

It is surprising to find private predicate methods with side-effects.

Change

Rename private predicate methods in GitCommandRunner to be more descriptive.

@johnsyweb johnsyweb requested a review from orien December 28, 2020 05:03
@johnsyweb johnsyweb mentioned this pull request Dec 28, 2020
Merged
orien
orien approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@orien orien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @johnsyweb!

@johnsyweb johnsyweb merged commit e1736ef into main Dec 28, 2020
@johnsyweb johnsyweb deleted the paj/rename-methods-with-side-effects branch December 28, 2020 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orien orien orien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnsyweb @orien