Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconciled flag for transaction needs to be settable for both source and destination account #528

Closed
morremeyer opened this issue Jan 6, 2023 · 0 comments · Fixed by #537
Closed

Reconciled flag for transaction needs to be settable for both source and destination account #528

morremeyer opened this issue Jan 6, 2023 · 0 comments · Fixed by #537
Labels
bug Something isn't working as supposed to

Comments

@morremeyer
Copy link
Member

morremeyer commented Jan 6, 2023 •
edited
Loading

Describe the bug

The reconciled flag is currently a single flag for the transaction. Since transactions are

Expected behavior

  • The reconciled flag needs to be settable for both the source and the destination account for a specific transaction.
  • For external accounts, it is always false

Implementation hints

For this fix, only add the new fields that are needed and a hint to the commit message to frontend implementers.
@morremeyer morremeyer added the bug Something isn't working as supposed to label Jan 6, 2023
This was referenced Jan 6, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as supposed to
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: reconciled flag per account envelope-zero/backend
1 participant
@morremeyer