Skip to content

Commit

Permalink
mobile: disable some virtual cluster stats (#24470)
Browse files Browse the repository at this point in the history
Commit Message:
Additional Description: Disable `upstream_rq_timeout` (this one does not work, see #23867), `upstream_rq_retry_success`, `upstream_rq_retry_overflow` and `upstream_rq_retry_limit_exceeded` stats to limit the number of stats that's created per every virtual cluster that Envoy Mobile is configured to start with. The list is somehow arbitrary and should eventually be moved out of the main config #24459. Reducing their number because of the performance concerns as stats as created as part of the virtual cluster creation which happens on app launch.
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):]
  • Loading branch information
Augustyniak committed Dec 12, 2022
1 parent 5db6783 commit ad6ae0d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mobile/library/common/config/config.cc
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@ stats_sinks: *stats_sinks
- safe_regex:
regex: '^pulse.*'
- safe_regex:
regex: '^vhost\.[\w]+\.vcluster\.[\w]+?\.upstream_rq_(?:[12345]xx|[3-5][0-9][0-9]|retry.*|timeout|total)'
regex: '^vhost\.[\w]+\.vcluster\.[\w]+?\.upstream_rq_(?:[12345]xx|[3-5][0-9][0-9]|retry|total)'
use_all_default_tags:
false
watchdogs:
Expand Down

0 comments on commit ad6ae0d

Please sign in to comment.