mobile stats: add a config knob for enabling stats #24459
Labels
enhancement
Feature requests. Not bugs or questions.
mobile
no stalebot
Disables stalebot from closing an issue
Comments
Augustyniak
added a commit
that referenced
this issue
Dec 12, 2022
Commit Message: Additional Description: Disable `upstream_rq_timeout` (this one does not work, see #23867), `upstream_rq_retry_success`, `upstream_rq_retry_overflow` and `upstream_rq_retry_limit_exceeded` stats to limit the number of stats that's created per every virtual cluster that Envoy Mobile is configured to start with. The list is somehow arbitrary and should eventually be moved out of the main config #24459. Reducing their number because of the performance concerns as stats as created as part of the virtual cluster creation which happens on app launch. Risk Level: Low Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Title: A method on the engine builder that allows to enable extra envoy stats
Description:
Envoy Mobile hardcodes the list of Envoy stats that it enables as part of its config.cc file in here. Add methods to engine builder(s) that allow the users of Envoy Mobile to enable the stats that they are interested in a more dynamic way.
The text was updated successfully, but these errors were encountered: