mobile: disable some virtual cluster stats #24470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Augustyniak
requested review from
jpsim,
RyanTheOptimist,
alyssawilk and
abeyad
as code owners
abeyad
previously approved these changes
Dec 9, 2022
abeyad
previously approved these changes
Dec 9, 2022
Augustyniak
force-pushed
the
disable-some-virtual-cluster-stats
branch
from
ffb4ef9
to
4960dea
Compare
jpsim
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description: Disable
upstream_rq_timeout(this one does not work, see #23867),upstream_rq_retry_success,upstream_rq_retry_overflowandupstream_rq_retry_limit_exceededstats to limit the number of stats that's created per every virtual cluster that Envoy Mobile is configured to start with. The list is somehow arbitrary and should eventually be moved out of the main config #24459. Reducing their number because of the performance concerns as stats as created as part of the virtual cluster creation which happens on app launch.Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]