Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry extension should set service.name resource attribute #22183

Closed
jmacd opened this issue Jul 13, 2022 · 3 comments · Fixed by #22472
Closed

OpenTelemetry extension should set service.name resource attribute #22183

jmacd opened this issue Jul 13, 2022 · 3 comments · Fixed by #22472

Comments

@jmacd
Copy link
Contributor

jmacd commented Jul 13, 2022

Title: Set the OpenTelemetry service.name resource attribute

Description:
OpenTelemetry specifies semantic conventions for services to meet, the most basic being the service's name.

Repro steps:
First reported here: #21370 (comment)

The Envoy should emit well-formed OTLP span data. The OpenTelemetry conventions require a service.name resource attribute, so one should be set either using configuration or a default value. OpenTelemetry specifies how to pick a default value, for example:

[1]: MUST be the same for all instances of horizontally scaled services. If the value was not specified, SDKs MUST fallback to unknown_service: concatenated with process.executable.name, e.g. unknown_service:bash. If process.executable.name is not available, the value MUST be set to unknown_service.

@jmacd jmacd added bug triage Issue requires triage labels Jul 13, 2022
@moderation
Copy link
Contributor

Looking at some traces being sent by the new Otel tracer, it looks like it is adhering to the spec but it would be nice to have additional information sent here from the Envoy config
image

@AlexanderEllis
Copy link
Contributor

Good catch! I think this should be relatively simply to set up and pipe through — I'm imagining a new optional field in the OpenTelemetryConfig proto, then checking for it or defaulting to unknown_service (or maybe unknown_service:envoy, which seems like a sensible default in this case) when building the ResourceSpans proto during export.

@phlax phlax added area/opentelemetry and removed triage Issue requires triage labels Jul 18, 2022
@phlax
Copy link
Member

phlax commented Jul 18, 2022

@AlexanderEllis i have assigned this to you - i hope that is ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants