Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How source_cluster is propagated to upstream service #35015

Closed
s-krawczyk opened this issue Jul 2, 2024 · 3 comments
Closed

How source_cluster is propagated to upstream service #35015

s-krawczyk opened this issue Jul 2, 2024 · 3 comments
Labels
area/ratelimit question Questions that are neither investigations, bugs, nor enhancements stale stalebot believes this issue/PR has not been touched recently

Comments

@s-krawczyk
Copy link

Description:
I try to use rate_limit with actions. Configured descriptor like below:

route: rate_limits: - actions: - source_cluster: {} -
That does not work. I am not getting any source_cluster. How this value flow from downstream service to upstream (destination) one? Is it a header? Does it even work? Any help or example would be helpful. Already sped 3 days on it. Reading source code etc. I would appreciate any direction. I want to use it for local rate limit.

Relevant Links:
>Any extra documentation required to understand the issue.
https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/route/v3/route_components.proto#config-route-v3-ratelimit-action

@s-krawczyk s-krawczyk added the triage Issue requires triage label Jul 2, 2024
@htuch
Copy link
Member

htuch commented Jul 2, 2024

@wbpcode @mattklein123

Are you setting the same source cluster in the Envoy CLI and in the config? It's a little unclear from the OP.

@htuch htuch added question Questions that are neither investigations, bugs, nor enhancements area/ratelimit and removed triage Issue requires triage labels Jul 2, 2024
Copy link

github-actions bot commented Aug 1, 2024

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Aug 1, 2024
Copy link

github-actions bot commented Aug 8, 2024

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ratelimit question Questions that are neither investigations, bugs, nor enhancements stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

2 participants