Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Envoy & otel tracing samplers #35016

Closed
dormullor opened this issue Jul 2, 2024 · 3 comments
Closed

Envoy & otel tracing samplers #35016

dormullor opened this issue Jul 2, 2024 · 3 comments
Labels
area/opentelemetry area/tracing enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently

Comments

@dormullor
Copy link

dormullor commented Jul 2, 2024

Hello everyone,
As far as i know, the default envoy OTEL sampler is "always_on", means, it will send a span for every request.
Since we use OTEL library on other services like nginx for example. i would like to set the nginx to a ratio based sampler and then envoy and all other services will use the "parentbased_always_off". ( if a trace exist, send a span, if not, do nothing )

https://opentelemetry.io/docs/languages/sdk-configuration/general/#otel_traces_sampler

Is there a way to configure other samplers in envoy ?

@dormullor dormullor added the triage Issue requires triage label Jul 2, 2024
@htuch
Copy link
Member

htuch commented Jul 2, 2024

@htuch htuch added enhancement Feature requests. Not bugs or questions. area/tracing area/opentelemetry and removed triage Issue requires triage labels Jul 2, 2024
Copy link

github-actions bot commented Aug 1, 2024

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Aug 1, 2024
Copy link

github-actions bot commented Aug 8, 2024

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/opentelemetry area/tracing enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

2 participants