ext_proc: Stop timers during ExternalProcessing::Filter::onDestroy #22541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a timer fires after onDestroy is called, the ext_proc filter may crash while trying to access invalid encoder or decoder filter callbacks. The documentation for StreamFilterBase::onDestroy() says, "Filters must not invoke either encoder or decoder filter callbacks after having onDestroy() invoked." Signed-off-by: Rick Stewart <ristewart@google.com>
|
/assign @mpwarres @PiotrSikora |
mpwarres
previously approved these changes
Aug 3, 2022
|
You might also consider adding a test case to ext_proc_integration_test.cc similar to ExtProcIntegrationTest.ResponseMessageTimeout, but with the added element that the downstream disconnects before time is advanced. |
Signed-off-by: Rick Stewart <ristewart@google.com>
Done. |
mpwarres
previously approved these changes
Aug 4, 2022
snowp
previously approved these changes
Aug 9, 2022
Signed-off-by: Rick Stewart <ristewart@google.com>
|
/retest |
|
Retrying Azure Pipelines: |
|
/retest |
|
Retrying Azure Pipelines: |
…s_on_decode Signed-off-by: Rick Stewart <ristewart@google.com>
Thanks! I fixed the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rick Stewart ristewart@google.com
Commit Message: If a timer fires after onDestroy is called, the ext_proc filter may crash while trying to access invalid encoder or decoder filter callbacks. The documentation for StreamFilterBase::onDestroy() says, "Filters must not invoke either encoder or decoder filter callbacks after having onDestroy() invoked." envoy-security@googlegroups.com said it's OK to upstream this since ext_proc is marked alpha.
Additional Description:
Risk Level: Low
Testing: Unit tests added
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]