Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext_proc: Stop timers during ExternalProcessing::Filter::onDestroy #22541

Merged
merged 4 commits into from
Aug 12, 2022

Commits on Aug 1, 2022

  1. Stop timers during ExternalProcessing::Filter::onDestroy

    If a timer fires after onDestroy is called, the ext_proc filter may crash while
    trying to access invalid encoder or decoder filter callbacks. The documentation
    for StreamFilterBase::onDestroy() says, "Filters must not invoke either
    encoder or decoder filter callbacks after having onDestroy() invoked."
    
    Signed-off-by: Rick Stewart <ristewart@google.com>
    Rick Stewart committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    47a7886 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2022

  1. Address review comments.

    Signed-off-by: Rick Stewart <ristewart@google.com>
    Rick Stewart committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    2940127 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2022

  1. Fix broken tests.

    Signed-off-by: Rick Stewart <ristewart@google.com>
    Rick Stewart committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    ec85f02 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2022

  1. Merge remote-tracking branch 'upstream/main' into ext_proc_stop_timer…

    …s_on_decode
    
    Signed-off-by: Rick Stewart <ristewart@google.com>
    Rick Stewart committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    4144e65 View commit details
    Browse the repository at this point in the history