Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: turning up release validation CI #24171

Merged
merged 4 commits into from
Nov 28, 2022
Merged

Conversation

alyssawilk
Copy link
Contributor

@alyssawilk alyssawilk commented Nov 23, 2022

copied from the mobile repo, and edited to run for repo merge. Only runs for mobile PRs.

Risk Level: low
Testing: first push shows it worked successfully
Docs Changes: n/a
Release Notes: n/a
part of #23758

@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #24171 was opened by alyssawilk.

see: more, trace.

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@alyssawilk alyssawilk changed the title release validation mobile: turning up release validation CI Nov 24, 2022
@alyssawilk alyssawilk marked this pull request as ready for review November 24, 2022 00:10
@alyssawilk alyssawilk enabled auto-merge (squash) November 24, 2022 00:11
.gitignore Outdated
@@ -20,6 +20,7 @@
!\.yapfignore
!\.zuul
!\.zuul.yaml
!\.github/workflows/*
Copy link
Member

@phlax phlax Nov 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please dont do this - rather clean up the yaml

this is unnecessary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not necessary but it makes it a lot less annoying to change workflow files as it means git add * will add them.

Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, altho im a little concerned that we are adding a lot of CI that will still run when not strictly required

the paths (and paths-ignore) pattern for workflow triggers is cool - i checked re azp to do the same thing - it seems we can altho i think we probably still need to use the pattern we have discussed as it is more about not/triggering steps within a workflow there

i was a little bit confused by the .gitignore change - mostly because i could see that the yaml should not pass linting so assumed that it was to prevent linting

i realise now that it does the opposite - ie ensure those files are included - but its not necessary as there is already:

 15 !\.github

checking this confirms

$ touch .github/workflows/asdf
$ git status .github/workflows/
On branch tooling-yamllint2
Untracked files:
  (use "git add <file>..." to include in what will be committed)
	.github/workflows/asdf

re linting the reason these files were not picked up is due to it only searching for .yaml files and not .yml - im fixing that now (envoyproxy/toolshed#623)

and will lint the existing files as that lands

@phlax
Copy link
Member

phlax commented Nov 24, 2022

yaml lint/cleanup pr is #24197

@alyssawilk alyssawilk merged commit db51554 into envoyproxy:main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants