-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mobile: turning up release validation CI #24171
Conversation
b9c9b64
to
b6c1190
Compare
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
.gitignore
Outdated
@@ -20,6 +20,7 @@ | |||
!\.yapfignore | |||
!\.zuul | |||
!\.zuul.yaml | |||
!\.github/workflows/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please dont do this - rather clean up the yaml
this is unnecessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not necessary but it makes it a lot less annoying to change workflow files as it means git add * will add them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, altho im a little concerned that we are adding a lot of CI that will still run when not strictly required
the paths
(and paths-ignore
) pattern for workflow triggers is cool - i checked re azp to do the same thing - it seems we can altho i think we probably still need to use the pattern we have discussed as it is more about not/triggering steps within a workflow there
i was a little bit confused by the .gitignore
change - mostly because i could see that the yaml should not pass linting so assumed that it was to prevent linting
i realise now that it does the opposite - ie ensure those files are included - but its not necessary as there is already:
15 !\.github
checking this confirms
$ touch .github/workflows/asdf
$ git status .github/workflows/
On branch tooling-yamllint2
Untracked files:
(use "git add <file>..." to include in what will be committed)
.github/workflows/asdf
re linting the reason these files were not picked up is due to it only searching for .yaml
files and not .yml
- im fixing that now (envoyproxy/toolshed#623)
and will lint the existing files as that lands
yaml lint/cleanup pr is #24197 |
copied from the mobile repo, and edited to run for repo merge. Only runs for mobile PRs.
Risk Level: low
Testing: first push shows it worked successfully
Docs Changes: n/a
Release Notes: n/a
part of #23758