[ext_proc] Knob to forcibly clear route cache #33568
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a knob to forcibly clear the route cache in Envoy irrespective of the value of the clear_route_cache bit in the ProcessingResponse. Signed-off-by: Shriram Rajagopalan <rshriram@users.noreply.github.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
I like the idea. |
tyxia
reviewed
Apr 16, 2024
| // Prevents clearing the route-cache when the | ||
| // :ref:`clear_route_cache <envoy_v3_api_field_service.ext_proc.v3.CommonResponse.clear_route_cache>` | ||
| // field is set in an external processor response. | ||
| bool disable_clear_route_cache = 11; |
There was a problem hiding this comment.
We can not promote existing field to be an oneof field as it is a breaking API change. See API guide.
You can only use udpa.annotations.field_migrate).oneof_promotion in API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: [ext_proc] Knob to forcibly clear route cache
Additional Description: Add a knob to forcibly clear the route cache in Envoy irrespective of the value of the clear_route_cache bit in the ProcessingResponse.
Risk Level: Low
Testing: API only
Signed-off-by: Shriram Rajagopalan shriramr@google.com